Change: Cluster setup exception message shortened

[svteb]

Description

As explained in the referenced issue, there was an unnecessary stack trace printed out in install_cluster_tools and uninstall_cluster_tools if ./cnf-testsuite setup has not been run. This was remediated by replacing the raise command with puts. Additionally I made the informative message more explicit for new users.

Issues:

Refs: #1926

How has this been tested:

• Covered by existing integration testing
• Added integration testing to cover
• Verified all A/C passes
  • develop
  • master
  • tag/other branch
• Test environment
  • Shared Packet K8s cluster
  • New Packet K8s cluster
  • Kind cluster
• Have not tested

Types of changes:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Checklist:

Documentation

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• No updates required.

Code Review

• Does the test handle fatal exceptions, ie. rescue block

Issue

• Tasks in issue are checked off

[martin-mat]

lgtm

[svteb]

I completely forgot to run spec tests, which even discovered the lack of exit code 1 as mentioned by @martin-mat . Additionally I had to edit the spec tests so that they would match the output with the new one.

[martin-mat]

lgtm

[kosstennbl]

LGTM, should make spec test output clearer and less confusing.
Pls add comment to PR about reason for removing Log.info { "install_cluster_tools" }

[svteb]

LGTM, should make spec test output clearer and less confusing. Pls add comment to PR about reason for removing Log.info { "install_cluster_tools" }

The clustertools.install method prints that clustertools installation is ongoing:

  def self.install(host_namespace = true)
    Log.info { "ClusterTools install" }
    if host_namespace
      File.write("cluster_tools.yml", ManifestHostNamespaceTemplate.new().to_s)
    else
      File.write("cluster_tools.yml", ManifestTemplate.new().to_s)
    end
    KubectlClient::Apply.file("cluster_tools.yml", namespace: self.namespace!)
    wait_for_cluster_tools
  end

So just duplication removal.

[rich-l]

lgtm