Change: Cluster setup exception message shortened (#2055)

* Change: Cluster setup exception message shortened
Refs: #1926
- The unnecessary stack trace was not printed through e.message as I suspected
but due to raise itself. That is why I instead used puts to print out the informative
message and the e.message remained in the form of an info log.
- I also made the informative message more explicit as someone not used to the testsuite
might not have understood it.

Signed-off-by: svteb <[email protected]>

* fix: Remediation message made less explicit
Refs: #1926

Signed-off-by: svteb <[email protected]>

* Fix: Task fails with proper exit code and the spec tests are adjusted for new output
Refs: #1926

Signed-off-by: svteb <[email protected]>

* Style: Shortened spec test result checking and updated log message to Log.error
Refs: #1926

Signed-off-by: svteb <[email protected]>

---------

Signed-off-by: svteb <[email protected]>

Author: svteb

spec/cluster_setup_spec.cr

@@ -5,7 +5,6 @@ require "kubectl_client"
 require "cluster_tools"
 
 describe "Cluster Setup" do
-
   before_each do
     result = ShellCmd.run_testsuite("cleanup")
     result[:status].success?.should be_true
@@ -15,7 +14,7 @@ describe "Cluster Setup" do
     KubectlClient::Delete.command("namespace #{ClusterTools.namespace}")
     result = ShellCmd.run_testsuite("install_cluster_tools")
     result[:status].success?.should be_false
-    (/please run cnf-testsuite setup/ =~ result[:output]).should_not be_nil
+    (/Error: Namespace cnf-testsuite does not exist./ =~ result[:output]).should_not be_nil
   end
 
   it "'install_cluster_tools' should give a message if namespace does not exist even after setup", tags: ["cluster_setup"]  do
@@ -25,13 +24,12 @@ describe "Cluster Setup" do
 
     result = ShellCmd.run_testsuite("install_cluster_tools")
     result[:status].success?.should be_false
-    (/please run cnf-testsuite setup/ =~ result[:output]).should_not be_nil
+    (/Error: Namespace cnf-testsuite does not exist./ =~ result[:output]).should_not be_nil
   end
 
   it "'uninstall_cluster_tools' should give a message if namespace does not exist", tags: ["cluster_setup"]  do
     result = ShellCmd.run_testsuite("uninstall_cluster_tools")
     result[:status].success?.should be_false
-    (/please run cnf-testsuite setup/ =~ result[:output]).should_not be_nil
+    (/Error: Namespace cnf-testsuite does not exist./ =~ result[:output]).should_not be_nil
   end
-
 end

src/tasks/cluster_setup.cr

@@ -10,20 +10,22 @@ require "./utils/utils.cr"
 
 desc "Install CNF Test Suite Cluster Tools"
 task "install_cluster_tools" do |_, args|
-  Log.info { "install_cluster_tools" }
-
   begin
     ClusterTools.install
   rescue e : ClusterTools::NamespaceDoesNotExistException 
-    raise "#{e.message}. please run cnf-testsuite setup!"
+    Log.error { "#{e.message}" }
+    stdout_failure "Error: Namespace cnf-testsuite does not exist.\nPlease run 'cnf-testsuite setup' to create the necessary namespace."
+    exit(1)
   end
 end
 
 desc "Uninstall CNF Test Suite Cluster Tools"
 task "uninstall_cluster_tools" do |_, args|
   begin
     ClusterTools.uninstall
-  rescue e : ClusterTools::NamespaceDoesNotExistException 
-    raise "#{e.message}. please run cnf-testsuite setup!"
+  rescue e : ClusterTools::NamespaceDoesNotExistException
+    Log.error { "#{e.message}" }
+    stdout_failure "Error: Namespace cnf-testsuite does not exist.\nPlease run 'cnf-testsuite setup' to create the necessary namespace."
+    exit(1)
   end
 end