Sync lexer punctuations with ZetaSQL #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makenowjust
reviewed
Oct 29, 2024
| @@ -132,7 +145,6 @@ var lexerWrongTestCase = []struct { | |||
| pos Pos | |||
| message string | |||
| }{ | |||
| {"?", 0, "illegal input character: '?'"}, | |||
There was a problem hiding this comment.
Is it hard to rewrite this test instead of removing?
There was a problem hiding this comment.
Hmm, I think there is no ASCII printable character remaining.
If we want to leave illegal character test case, we need to use unprintable character or some unicode chatecters.
I would try to use \b(beep character)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all ZetaSQL punctuations as memefish tokens.
MACRO_*are not yet implemented because they are not yet used and can be tokenized as"$" Ident,"$" IntLiteral, but they are not trivial to implement.fixes #181