We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some punctuations are not yet handled in memefish.Lexer. It cause panic when lexing even if parsing is not needed.
memefish.Lexer
I think it is safe to add all punctuations in ZetaSQL.
https://github.com/google/zetasql/blob/194cd32b5d766d60e3ca442651d792c7fe54ea74/zetasql/parser/flex_tokenizer.l#L513-L552
(
[
{
)
]
}
*
,
=
+=
KW_ADD_ASSIGN
options_assignment_operator
-=
KW_SUB_ASSIGN
!=
<=
<<
=>
->
KW_LAMBDA_ARROW
<
>
>=
||
|
^
&
+
-
/
~
?
Positional parameters are not supported
!
%
|>
KW_PIPE
@
@@
KW_DOUBLE_AT
.
:
NEW
\
BACKSLASH
;
${unquoted_identifier}
MACRO_INVOCATION
${decimal_digits}
MACRO_ARGUMENT_REFERENCE
$
Except MACRO_INVOCATION and MACRO_ARGUMENT_REFERENCE would be better to be implemented.
This makes Lexer more robust even to new lexical structures that are being tested privately.
Lexer
The text was updated successfully, but these errors were encountered:
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Some punctuations are not yet handled in
memefish.Lexer.It cause panic when lexing even if parsing is not needed.
I think it is safe to add all punctuations in ZetaSQL.
https://github.com/google/zetasql/blob/194cd32b5d766d60e3ca442651d792c7fe54ea74/zetasql/parser/flex_tokenizer.l#L513-L552
([{)]}*,=+=KW_ADD_ASSIGNoptions_assignment_operator-=KW_SUB_ASSIGNoptions_assignment_operator!=<=<<=>->KW_LAMBDA_ARROW<>>=|||^&+-/~?!%|>KW_PIPE@@@KW_DOUBLE_AT.:NEWconstructors Support protobuf NEW operators #119\BACKSLASH;${unquoted_identifier}MACRO_INVOCATION${decimal_digits}MACRO_ARGUMENT_REFERENCE$Except
MACRO_INVOCATIONandMACRO_ARGUMENT_REFERENCEwould be better to be implemented.This makes
Lexermore robust even to new lexical structures that are being tested privately.The text was updated successfully, but these errors were encountered: