feat: Add slot for custom controls in absolute range date picker #531
Conversation
| @@ -38,10 +38,6 @@ $calendar-header-color: awsui.$color-text-body-default; | |||
| } | |||
|
|
|||
| .calendar { | |||
| display: block; | |||
| width: 100%; | |||
| margin-bottom: awsui.$space-scaled-s; | |||
There was a problem hiding this comment.
Replaced this with SpaceBetween component. Screenshot tests shown no difference
Codecov ReportBase: 92.58% // Head: 92.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 569 569
Lines 16162 16174 +12
Branches 4419 4421 +2
=======================================
+ Hits 14963 14975 +12
Misses 1118 1118
Partials 81 81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| { | ||
| value: [{ start: { date: '', time: '' }, end: { date: '', time: '' } }], | ||
| setValue: [() => {}], | ||
| i18nStrings: [i18nStrings], | ||
| customAbsoluteRangeControl: [() => 'Custom control'], | ||
| }, |
There was a problem hiding this comment.
This addition caused visual regression tests to fail (backstop does not automatically detect and skip added permutations, unlike our internal engine).
All other tests are good
just-boris
force-pushed
the
drp-absolute-shortcuts
branch
from
82b86dc to
fd1e578
Compare
just-boris
force-pushed
the
drp-absolute-shortcuts
branch
from
fd1e578 to
4a4a29a
Compare
Description
Allow to render a custom control in absolute selection mode. Check the new
custom-control.page.tsxdemo for usage example.Related links, issue #, if available: n/a
How has this been tested?
Locally, build in my dev-pipeline (link in DM)
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.