Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore: Underline styles for popover text trigger (#3060)" #3223

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

georgylobko
Copy link
Contributor

This reverts commit e1c488b.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (0be1ec7) to head (dab021d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3223   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files         790      790           
  Lines       22249    22249           
  Branches     7231     7231           
=======================================
  Hits        21458    21458           
  Misses        784      784           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgylobko georgylobko marked this pull request as ready for review January 27, 2025 12:58
@georgylobko georgylobko requested a review from a team as a code owner January 27, 2025 12:58
@georgylobko georgylobko requested review from cansuaa and removed request for a team January 27, 2025 12:58
@georgylobko georgylobko added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit c204e53 Jan 27, 2025
38 checks passed
@georgylobko georgylobko deleted the revert/underline-popover-styles branch January 27, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants