-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Underline styles for popover text trigger #3060
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
========================================
Coverage 96.41% 96.41%
========================================
Files 784 784
Lines 22168 22168
Branches 7206 7608 +402
========================================
Hits 21373 21373
Misses 788 788
Partials 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaeldowseza
I’ve addressed this discrepancy and reviewed the screenshot tests in my dev pipeline. Everything looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a designer’s input to review the changes in this PR. @jkuelz
Posting all main diffs we have now:
live:
current (underline applies only to the text, not to the icon):
live:
current (the underline became thicker):
live:
current (multi-line underline, which is the whole point of this PR):
Description
AWSUI-59855
Replaced border bottom with underline dotted styles.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.