Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Underline styles for popover text trigger #3060

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

georgylobko
Copy link
Contributor

@georgylobko georgylobko commented Nov 26, 2024

Description

AWSUI-59855
Replaced border bottom with underline dotted styles.

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (f9aeff8) to head (639d40f).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3060    +/-   ##
========================================
  Coverage   96.41%   96.41%            
========================================
  Files         784      784            
  Lines       22168    22168            
  Branches     7206     7608   +402     
========================================
  Hits        21373    21373            
  Misses        788      788            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgylobko georgylobko marked this pull request as ready for review December 2, 2024 13:18
@georgylobko georgylobko requested a review from a team as a code owner December 2, 2024 13:18
@georgylobko georgylobko requested review from michaeldowseza and removed request for a team December 2, 2024 13:18
@michaeldowseza
Copy link
Member

Are all visual differences to be expected from this? e.g. Slight change in dotted line + slight shift in where the popover appears from?

image

Copy link
Contributor Author

@georgylobko georgylobko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaeldowseza
I’ve addressed this discrepancy and reviewed the screenshot tests in my dev pipeline. Everything looks good now.

Copy link
Contributor Author

@georgylobko georgylobko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a designer’s input to review the changes in this PR. @jkuelz
Posting all main diffs we have now:

live:
image
current (underline applies only to the text, not to the icon):
image

live:
image
current (the underline became thicker):
image

live:
image
current (multi-line underline, which is the whole point of this PR):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants