chore: Fix elements scrolling with elementScrollTo in integration tests #3138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Dani
commented
Dec 13, 2024
| @@ -44,7 +44,7 @@ describe('Cards Sticky Header', () => { | |||
| const scrollTopToBtn = '#scroll-to-top-btn'; | |||
| const toggleStickinessBtn = '#toggle-stickiness-btn'; | |||
| const toggleVerticalOffsetBtn = '#toggle-vertical-offset-btn'; | |||
| const overflowParentPageHeight = 300; | |||
There was a problem hiding this comment.
it isn't failing, but also doesn't match with actual height https://github.com/cloudscape-design/components/blob/main/pages/cards/sticky-header.page.tsx#L68
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3138 +/- ##
==========================================
+ Coverage 96.39% 96.40% +0.01%
==========================================
Files 784 784
Lines 22059 22131 +72
Branches 7159 7530 +371
==========================================
+ Hits 21263 21336 +73
+ Misses 789 743 -46
- Partials 7 52 +45 ☔ View full report in Codecov by Sentry. |
Al-Dani
force-pushed
the
non-scrollable-tests
branch
from
356e3c5 to
28c6984
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| function execCommand(command, options = {}) { | ||
| try { | ||
| execSync(command, { stdio: 'inherit', ...options }); |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available:
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.