feat: Validate if an element to scroll is actually scrollable #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 18 18
Lines 396 396
Branches 63 63
=======================================
Hits 363 363
Misses 29 29
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Al-Dani
force-pushed
the
scroll-validation
branch
from
36df5ff to
0e044e0
Compare
Al-Dani
force-pushed
the
scroll-validation
branch
from
0e044e0 to
13536da
Compare
Al-Dani
force-pushed
the
scroll-validation
branch
from
ea32eb9 to
01245fa
Compare
Al-Dani
force-pushed
the
scroll-validation
branch
from
01245fa to
7755d68
Compare
Al-Dani
force-pushed
the
scroll-validation
branch
from
7755d68 to
7546b00
Compare
taheramr
previously approved these changes
Feb 25, 2025
src/browser-scripts/scroll.ts
Outdated
| throw new Error('Element ' + selector + ' has not been found at the page'); | ||
| const overflowStyles = getComputedStyle(element)[overflowDirection].split(' '); | ||
| if (!overflowStyles.includes('auto') && !overflowStyles.includes('scroll') && element !== document.documentElement) { | ||
| throw new Error('Element ' + selector + ' is not scrollable'); |
There was a problem hiding this comment.
can we align using the formatting of errors strings? I see some exaples using the `` and some using '' + ''
could it be:
throw new Error(`Element ${selector} is not scrollable`);
src/browser-scripts/scroll.ts
Outdated
| } | ||
| element.scrollTop = top; | ||
| element.scrollLeft = left; | ||
| } | ||
|
|
||
| export function getElementScrollPosition(selector: string): ScrollPosition { | ||
| var element = document.querySelector(selector); |
There was a problem hiding this comment.
Away from the changes but can this be const instead?
taheramr
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Make sure that we attempt to scroll an element which is actually scrollable
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.