fix: Improve progress bar color contrast in warning flash message #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arning f…" This reverts commit 37e8488.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2652 +/- ##
==========================================
- Coverage 95.84% 95.84% -0.01%
==========================================
Files 744 744
Lines 20581 20581
Branches 7015 7024 +9
==========================================
- Hits 19726 19725 -1
+ Misses 847 800 -47
- Partials 8 56 +48 ☔ View full report in Codecov by Sentry. |
jperals
reviewed
Sep 10, 2024
| @@ -94,14 +94,11 @@ $background-color-in-flash: awsui.$color-background-progress-bar-layout-in-flash | |||
| $bar-color: awsui.$color-background-progress-bar-content-default; | |||
| $bar-color-in-flash: awsui.$color-background-progress-bar-content-in-flash; | |||
|
|
|||
| // Current version of Edge has a known bug with CSS variables used in pseudo elements. | |||
There was a problem hiding this comment.
Do we know that this is not necessary anymore?
There was a problem hiding this comment.
"Current version of Edge" here is referring to EdgeHTML, before Edge switched to using Chromium as its base.
jperals
approved these changes
Sep 10, 2024
avinashbot
deleted the
revert-2518-revert-2480-warning-flash-progress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to revert this PR because Firefox didn't like it. Now fixed (see second commit) and tested in my dev pipeline, so we're good to go.