revert: Revert "fix: Improve progress bar color contrast in warning flash message" #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashbot
requested review from
georgylobko and
gethinwebster
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
==========================================
- Coverage 95.75% 95.74% -0.01%
==========================================
Files 726 726
Lines 19747 19747
Branches 6659 6711 +52
==========================================
- Hits 18908 18907 -1
- Misses 784 785 +1
Partials 55 55 ☔ View full report in Codecov by Sentry. |
georgylobko
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2480
Progress bar color styling was no longer being applied in Chrome for some reason. My working guess is that it's now defined in the same rule next to the -moz- styling, and that breaks it somehow? Reverting to unblock our releases.