Skip to content

Add a new sidecar rootfs property to the rep #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Add a new sidecar rootfs property to the rep #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75a8964
Add the sidecar rootfs prop
ivo1116 Feb 6, 2025
8bf3b85
add default value to rootfs prop
ivo1116 Feb 7, 2025
5c1665f
improve description
ivo1116 Feb 7, 2025
90f9123
fix indent bug
ivo1116 Feb 7, 2025
456c6de
Update the description to be more specific
ivo1116 Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jobs/rep/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ properties:
default: false
diego.rep.preloaded_rootfses:
description: "Array of name:absolute_path pairs representing root filesystems preloaded onto the underlying garden"
diego.rep.sidecar_rootfs_path:
Copy link
Member

@ameowlia ameowlia Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description to...

  1. Include an example
  2. Say that empty string is okay
  3. describe what will happen if this property is set to an empty string

description: "absolute_path representing the root filesystem used for sidecar processes (ie. "/var/vcap/packages/cflinuxfs4/rootfs.tar"). Must be one of the preloaded_rootfses paths. Leaving the default empty string is ok, as it will then select the first of he preloaded_rootfses"
default: ""
diego.rep.rootfs_providers:
description: "Array of schemes for which the underlying garden can support arbitrary root filesystems"
default:
Expand Down
1 change: 1 addition & 0 deletions jobs/rep/templates/rep.json.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
placement_tags: p("diego.rep.placement_tags"),
polling_interval: "#{p("diego.rep.polling_interval_in_seconds")}s",
preloaded_root_fs: p("diego.rep.preloaded_rootfses"),
sidecar_root_fs_path: p("diego.rep.sidecar_rootfs_path"),
read_work_pool_size: p("diego.executor.read_work_pool_size"),
skip_cert_verify: p("diego.ssl.skip_cert_verify"),
supported_providers: p("diego.rep.rootfs_providers"),
Expand Down