Add a new sidecar rootfs property to the rep #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameowlia
requested changes
Feb 13, 2025
| default: false | ||
| diego.rep.preloaded_rootfses: | ||
| description: "Array of name:absolute_path pairs representing root filesystems preloaded onto the underlying garden" | ||
| diego.rep.sidecar_rootfs_path: |
Member
There was a problem hiding this comment.
Can you update the description to...
- Include an example
- Say that empty string is okay
- describe what will happen if this property is set to an empty string
ameowlia
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR makes sure the FSes are used in a consistent way. We have added a SidecarRootFSPath that will store the FS to be used for the envoy & healthchecks. The default behaviour will remain the same, but when the property is specified, the sidecar processes will use it.
The github issue: #983
Backward Compatibility
Breaking Change? No
No breaking changes, just making sure the fses are used in a consistent way