-
Notifications
You must be signed in to change notification settings - Fork 218
Adds diego windows stub to README. #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey mavenraven! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/93541332. |
|
Hi @mavenraven, When doing this locally it adds the Thanks, |
|
Hey @luan, I've changed the PR to call out better that it's only for operators who are running Windows cells. Unfortunately, there's not a good way to know at manifest generation time whether Windows will running in an automatic way. Thanks! |
|
One way is to tell operators to include the windows stub if and only if they are going to deploy windows. Its similar to how we deploy diego with cf-release. |
|
Merged into develop |
Submodule src/code.cloudfoundry.org/cacheddownloader 5dac67c88..aa1b1779f: > Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 (#36) Submodule src/code.cloudfoundry.org/credhub-cli 6b3dc17b1..cdbb1ac98: > Bump go modules
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9c4775059..db1b8a445: > Merge pull request #74 from cloudfoundry/fix-window Submodule src/code.cloudfoundry.org/executor 5c6320b..e9e6113: > Avoid race condition in new cacheddownloader test (#109) Submodule src/code.cloudfoundry.org/inigo 0b7dbcf..d30700a: > Update broken links in docs (#36)
This change ensures the constant name matches all the others. We missed this one in [1] [1]: cloudfoundry/bbs@bba43ff. closes cloudfoundry#36 [#126557839](https://www.pivotaltracker.com/story/show/126557839)
Context: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/118 After Adding cloudfoundry/route-emitter#34 it takes up-to 30Sec to connect with NATS. This was causing an issue for the tests when it wasn't wait long enough to have the service up and running. Additionally, killing nats server in the test to run it with TLS was failing the retry logic. Instead, we are always running NATS with TLS in the suite.
…aemon The default for the timeout is 5 minutes. **note** ssh keep alive will (as expected) prevent the timeout from taking place. [closes cloudfoundry#36] Signed-off-by: Nima Kaviani <[email protected]>
No description provided.