Skip to content

Conversation

@mavenraven
Copy link
Contributor

No description provided.

@cfdreddbot
Copy link

Hey mavenraven!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/93541332.

@luan
Copy link
Contributor

luan commented May 8, 2015

Hi @mavenraven,

When doing this locally it adds the windows2012R2 stack to my CF (which will not work since I don't have that set up), that makes it a little confusing for someone deploying CF + Diego to bosh-lite.
Is there a way we can get this to be somewhat optional so whoever is generating the manifest will only enable windows if they have that capability?

Thanks,
@luan, CF Diego Team

@mavenraven
Copy link
Contributor Author

Hey @luan, I've changed the PR to call out better that it's only for operators who are running Windows cells. Unfortunately, there's not a good way to know at manifest generation time whether Windows will running in an automatic way. Thanks!

@fraenkel
Copy link
Contributor

fraenkel commented May 8, 2015

One way is to tell operators to include the windows stub if and only if they are going to deploy windows. Its similar to how we deploy diego with cf-release.

@matt-royal
Copy link
Contributor

Merged into develop

@matt-royal matt-royal closed this May 20, 2015
tas-runtime-bot added a commit that referenced this pull request Mar 26, 2024
Submodule src/code.cloudfoundry.org/cacheddownloader 5dac67c88..aa1b1779f:
  > Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 (#36)
Submodule src/code.cloudfoundry.org/credhub-cli 6b3dc17b1..cdbb1ac98:
  > Bump go modules
tas-runtime-bot added a commit that referenced this pull request Apr 25, 2024
Submodule src/code.cloudfoundry.org/route-emitter 7ae5cf4..845968c:
  > Fix failing tests (#36)
Submodule src/guardian 1bbd61179..b9ea02f28:
  > Update go.mod dependencies
tas-runtime-bot added a commit that referenced this pull request Oct 8, 2024
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9c4775059..db1b8a445:
  > Merge pull request #74 from cloudfoundry/fix-window
Submodule src/code.cloudfoundry.org/executor 5c6320b..e9e6113:
  > Avoid race condition in new cacheddownloader test (#109)
Submodule src/code.cloudfoundry.org/inigo 0b7dbcf..d30700a:
  > Update broken links in docs (#36)
kart2bc pushed a commit to kart2bc/diego-release that referenced this pull request Aug 19, 2025
This change ensures the constant name matches all the others. We missed this
one in [1]

[1]: cloudfoundry/bbs@bba43ff.

closes cloudfoundry#36
[#126557839](https://www.pivotaltracker.com/story/show/126557839)
kart2bc pushed a commit to kart2bc/diego-release that referenced this pull request Aug 22, 2025
Context: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/118

After Adding cloudfoundry/route-emitter#34 it takes up-to 30Sec to
connect with NATS. This was causing an issue for the tests when it
wasn't wait long enough to have the service up and running.

Additionally, killing nats server in the test to run it with TLS was
failing the retry logic. Instead, we are always running NATS with TLS in
the suite.
kart2bc pushed a commit to kart2bc/diego-release that referenced this pull request Aug 25, 2025
kart2bc pushed a commit to kart2bc/diego-release that referenced this pull request Aug 25, 2025
…aemon

The default for the timeout is 5 minutes. **note** ssh keep alive will (as
expected) prevent the timeout from taking place.

[closes cloudfoundry#36]

Signed-off-by: Nima Kaviani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants