This repository was archived by the owner on Sep 11, 2025. It is now read-only.
fail if greet never succeeds #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bosh will mark route emitter as failing * bosh will restart the route emitter and it will retry greeting again * route emitter logs that it is ready AFTER greet loop succeeds
winkingturtle-vmw
added a commit
that referenced
this pull request
Apr 25, 2024
Context: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/118 After Adding #34 it takes up-to 30Sec to connect with NATS. This was causing an issue for the tests when it wasn't wait long enough to have the service up and running. Additionally, killing nats server in the test to run it with TLS was failing the retry logic. Instead, we are always running NATS with TLS in the suite.
MarcPaquette
pushed a commit
that referenced
this pull request
Apr 25, 2024
Context: https://ci.funtime.lol/teams/wg-arp-diego/pipelines/diego-release/jobs/unit-and-integration-tests/builds/118 After Adding #34 it takes up-to 30Sec to connect with NATS. This was causing an issue for the tests when it wasn't wait long enough to have the service up and running. Additionally, killing nats server in the test to run it with TLS was failing the retry logic. Instead, we are always running NATS with TLS in the suite.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fail if greet never succeeds
Backward Compatibility
Breaking Change? No