Skip to content

Conversation

@axelaris
Copy link
Contributor

Hi!
This PR is for automatic setting api & apps_domain values for Smoke & Acceptance tests.
I hope you will like this PR.

@cfdreddbot
Copy link

Hey axelaris!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

1 similar comment
@cfdreddbot
Copy link

Hey axelaris!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/108939428.

@emalm
Copy link
Contributor

emalm commented Nov 30, 2015

Thanks, @axelaris! I think we'll probably pull in #109 from @Amit-PivotalLabs, which has a more substantial restructuring of these manifest-generation templates that would conflict with these changes.

I do like the idea of using the external CC URL from the CF manifest for the tests' API config value, though: that could be the default for the DAT and smoke-test errands, and could then be overridable via the separate test-properties stub that #109 introduces.

I'm not sure about using the system domain as the apps_domain value though: if we're going to extract a default from the CF manifest, it should be the first entry in the app_domains list, but again I think that should be overridable via the test-properties stub.

Best,
Eric

@Amit-PivotalLabs
Copy link

+1, it would be great for the test errand manifest templates to pull the API URL and apps domain from the CF manifest, just as the diego manifest does. I didn't want to conflate that work with my PR. @axelaris maybe you want to do that as a PR after the Diego team merges #109. Sorry for the clash.

@emalm
Copy link
Contributor

emalm commented Nov 30, 2015

From my perspective, those changes would be great to have as a follow-on PR to #109.

@axelaris
Copy link
Contributor Author

axelaris commented Dec 1, 2015

Ok guys,
I've subscribed to #109 notifications, and going to recheck my patch again once #109 is merged.

@axelaris
Copy link
Contributor Author

axelaris commented Dec 8, 2015

Hi @ematpl,
I've fixed my patch to intend #109.
Could you please check it.

@emalm
Copy link
Contributor

emalm commented Dec 8, 2015

Thanks, @axelaris! Since we now have a generic DATs template at https://github.com/cloudfoundry-incubator/diego-release/blob/develop/manifest-generation/diego-acceptance-tests.yml, we should flow values from the CF manifest into that template, rather than into the BOSH-Lite stubs. As I mentioned above, we should also take the first entry in the CF manifest's app_domains property as the default value for the acceptance_tests.apps_domain property, and the api and apps_domain values in the properties stub, if specified, should take precedence over these ones from the CF manifest.

Best,
Eric

@axelaris
Copy link
Contributor Author

@ematpl, done. Could you please check once again?

@emalm
Copy link
Contributor

emalm commented Dec 21, 2015

Thanks again, @axelaris! Looks right to me! Prioritized for the Diego team to evaluate this coming week.

Best,
Eric

@jfmyers9 jfmyers9 merged commit 5139d4d into cloudfoundry:develop Dec 22, 2015
jvshahid added a commit that referenced this pull request Jun 18, 2018
[finishes #155485548](https://www.pivotaltracker.com/story/show/155485548)

Submodule src/code.cloudfoundry.org/diego-ssh 9b3f460..1174556:
  > Upgrade jwt-go library.
Submodule src/code.cloudfoundry.org/uaa-go-client 0c176509..26b271e3:
  > Ignore validation error when token used before issued
  > go back to using submodules from routing-release
  > Provide correct url
  > Update README
  > all tests passing with newer JWT
  > fixing vet errors
  > Merge pull request #10 from cloudfoundry-incubator/vendor-deps
  > Revert "remove incubator"
  > remove incubator
Submodule src/github.com/dgrijalva/jwt-go f62f64ea..06ea1031:
  > documentation around expected key types
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > add options to ParseFromRequest
  > fixed a formatting error in a test
  > documenting changes for upcoming 3.2.0 release
  > Merge pull request #152 from pusher/parse-unverified
  > Merge pull request #219 from geertjanvdk/feat/parse
  > Merge pull request #205 from zamicol/icon_godoc
  > Merge pull request #209 from zhyuri/patch-1
  > Merge pull request #220 from polarina/readme-alt-include
  > Notice about upcoming 4.0.0 release
  > 3.1.0 changelog
  > Merge pull request #218 from zoofood/patch-1
  > updated note on alg type vulnerability
  > Merge pull request #183 from hnakamur/support_rs256_in_jwt_command
  > Merge pull request #196 from dgrijalva/dg/cmd_args
  > Merge pull request #190 from jamesrwhite/patch-1
  > Merge pull request #180 from kevinburke/fix-unreachable
  > Merge pull request #166 from johnlockwood-wf/issue-165-missing-arg
  > Merge pull request #151 from zaichang/FixMigrationGuide
  > Merge pull request #146 from pkieltyka/master
  > Merge pull request #140 from kazhuravlev/patch-1
  > Merge pull request #77 from dgrijalva/release_3_0_0
  > v2.7.0
  > notice about imminent 3.0.0
  > Merge pull request #136 from bruston/keyfunc-typo
  > fixes #135 copy/paste error in rsa decoding tools
  > Merge pull request #132 from abourget/master
  > Merge pull request #133 from johnlockwood-wf/expire-delta
  > release notes
  > expose inner error within ValidationError
  > Merge branch 'master' of https://github.com/emanoelxavier/jwt-go-contr into dg/merge_112
  > cleaned up style and added tests
  > Merge branch 'master' of https://github.com/dakom/jwt-go into dg/pr_121
  > version history update
  > Merge pull request #79 from dgrijalva/dg/none
  > Merge pull request #122 from appleboy/patch-1
  > add 1.6 to travis.yml
  > Merge pull request #107 from Snorlock/bearer-verification
  > Merge pull request #111 from matm/master
  > added supported signing methods
  > Added some clarification and (hopefully) helpful documentation
  > version history
  > signature should be populated after parsing a valid token
  > Merge pull request #98 from dgrijalva/dg/parser
  > use cleaner version of prefix checking (thanks shurcooL)
  > fix array OOB panic (#100)
  > Merge pull request #93 from EnerfisTeam/master
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > minor refactor of HMAC verify for legibility.  no functional changes
  > updated documenation of SigningMethod interface
winkingturtle-vmw pushed a commit that referenced this pull request Apr 6, 2023
bump auction auctioneer bbs buildpackapplifecycle bytefmt cacheddownloader cfdot diego-ssh dockerapplifecycle dockerdriver ecrhelper executor fileserver goshims healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts trace-logger vizzini volman workpool garden grootfs guardian idmapper

Submodule src/code.cloudfoundry.org/auction f4db6c5..20b5e4e:
  > Bump to ginkgo/v2 and lager/v3 (#10)
Submodule src/code.cloudfoundry.org/auctioneer 7b69d26..6757f66:
  > Bump to ginkgo/v2 and lager/v3 (#11)
Submodule src/code.cloudfoundry.org/bbs 952b49b..41bd09f:
  > fix for `go vet` failures (#63)
  > Bump to lager/v3 (remaining)
  > Bump sqldb/helpers + test helpers to lager v3 (#61)
  > Bump to ginkgo/v2
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9bfd77998..b3c0aa499:
  > Merge pull request #61 from cloudfoundry/with-ginkgo-v2
  > Merge pull request #59 from cloudfoundry/develop
Submodule src/code.cloudfoundry.org/cacheddownloader 456a733fa..3de1f8d2e:
  > Bump to ginkgo/v2 and lager/v3 (#23)
Submodule src/code.cloudfoundry.org/cfdot f68fa7f..9c6e1b4:
  > Bump to ginkgo/v2 and lager/v3 (#6)
Submodule src/code.cloudfoundry.org/diego-ssh 0fc4f3a..1003fb5:
  > Bump to ginkgo/v2 and lager/v3 (#47)
Submodule src/code.cloudfoundry.org/dockerapplifecycle 163faed..36aa909:
  > Bump to ginkgo/v2 (#11)
  > Regenerate test certificates
Submodule src/code.cloudfoundry.org/dockerdriver 16e1fe9ba..76bff1bc5:
  > Bump to ginkgo/v2 and lager/v3 (#3)
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/code.cloudfoundry.org/ecrhelper 9a7c7e5..3949c02:
  > Bump to ginkgo/v2 (#2)
Submodule src/code.cloudfoundry.org/executor 1e5a6f1..208a08c:
  > With ginkgo v2 and lager/v3 (#75)
  > Ensure we release info lock when marshaling fails
  > Update garden container logging tags
  > Fix typo in function name
  > Fetch all containers for cleanup
  > Executor releases resources only when a container is successfully deleted
Submodule src/code.cloudfoundry.org/fileserver 11af6ea..f3dfda9:
  > Bump to ginkgo/v2 && lager/v3 (#7)
Submodule src/code.cloudfoundry.org/goshims bb24d2ef7..cf8c6ba6c:
  > Bump golang.org/x/net from 0.7.0 to 0.8.0 (#24)
  > Bump golang.org/x/net from 0.0.0-20200301022130-244492dfa37a to 0.7.0 (#23)
  > Bump github.com/go-sql-driver/mysql from 1.6.0 to 1.7.0 (#22)
  > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#21)
  > Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)" (#20)
  > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)
  > Merge pull request #18 from cloudfoundry/dependabot/add-v2-config-file
  > Merge pull request #17 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.36.0
  > Merge pull request #16 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.35.0
  > Merge pull request #15 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.1
  > Merge pull request #14 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.0
  > Merge pull request #13 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.2
  > Merge pull request #12 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.1
  > Merge pull request #11 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.32.0
  > Merge pull request #10 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.1
  > Merge pull request #9 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.0
  > Merge pull request #8 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.30.0
  > go mod vendor
  > Merge pull request #7 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.29.1
  > 🤖 go mod vendor
  > go get -u all
  > Add gitignore file
  > Convert to go modules
  > Add SetEnv to the command interface
Submodule src/code.cloudfoundry.org/healthcheck d7f787b..7670cbf:
  > Bump to ginkgo/v2 (#9)
Submodule src/code.cloudfoundry.org/inigo 18bab03..3c8b1a8:
  > Bump to ginkgo/v2 & lager/v3 (#25)
Submodule src/code.cloudfoundry.org/localdriver 1b0a47b..0668dcc:
  > Bump to ginkgo/v2 & lager/v3 (#2)
Submodule src/code.cloudfoundry.org/locket 76a930295..5e8522d97:
  > {fake_runner,fake_runner_v2} to be used with (#14)
  > Add BeforeSuite in the right place
  > Fix govet errors
  > Bump to lager v3
  > WIP - upgrading to ginkgo v2+ ginkgomon_v2
Submodule src/code.cloudfoundry.org/operationq da3eb22..4522d08:
  > Bump to ginkgo/v2 (#2)
  > Fix the test for max capacity
  > Ginkgo v2: don't use Done channels
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/code.cloudfoundry.org/rep be8beeb..f627e21:
  > Bump to ginkgo/v2 && lager/v3 (#39)
Submodule src/code.cloudfoundry.org/route-emitter c907cd8..da039b0:
  > Bump to ginkgo/v2 && lager/v3 (#21)
Submodule src/code.cloudfoundry.org/routing-api ff096da8d..2bf566855:
  > Fix ginkgo deprecations with Done channels
  > Fix ginkgo v2 flag deprecation notices
  > Bump to lager v3
  > Convert  to ginkgo v2 + inline the archived trace package
  > Convert to ginkgo v2 + inline the archived trace package
  > ignore .test files in the repo
  > Bump to ginkgo/v2
  > Bump to ginkgo/v2 - WIP
  > Allow uaaclient callers to optionally pass in a protocol via (#30)
Submodule src/code.cloudfoundry.org/routing-info 7d023ecb0..c6998d604:
  > Bump to ginkgo/v2
Submodule src/code.cloudfoundry.org/systemcerts 95ea366d9..5244fcb1b:
  > refactor: rm use of internal/testenv
Submodule src/code.cloudfoundry.org/vizzini a59096109...6474f903a:
  > fix `go vet` failures
  > Bump to ginkgo/v2 && lager/v3
  < Fix one more test using metric tags
Submodule src/code.cloudfoundry.org/volman 4129b31..76091d5:
  > Bump to ginkgo/v2 && lager/v3 (#5)
Submodule src/code.cloudfoundry.org/workpool e8b9128..2e26d5d:
  > Bump to ginkgo/v2 (#2)
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/garden d57de807d..8534099e1:
  > Migrate to lager v3
  > Migrate to ginkgo/v2
  > Bump lager to latest on master
  > Revert "bump ginkgo to v2 and lager to v3"
  > Merge pull request #107 from xtremerui/bump-ginkgo-lager
  > Bump golang.org/x/net from 0.0.0-20210428140749-89ef3d95e781 to 0.7.0
  > Merge pull request #105 from cloudfoundry/unpin-components
  > Merge pull request #103 from ebroberson/ginkgov2-done-channels
Submodule src/grootfs ba02da43d..df476b3ba:
  > Swtch to channels from pool
  > Return to pool xfs mounts that don't cause test pollution
  > Generate 10 mount points for all quota tests
  > Use unique mount directory for each test
  > Merge pull request #197 from cloudfoundry/with-ginkgo-v2
  > go mod tidy && vendor
  > Bump lager to latest on master
  > 🔒 dep
  > Merge pull request #196 from cloudfoundry/unpin-components
  > Bump golang.org/x/sys from 0.5.0 to 0.6.0
  > go mod tidy
  > Merge remote-tracking branch 'local/dependabot/go_modules/code.cloudfoundry.org/lager-2.0.0incompatible' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/containers/image/v5-5.24.2' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/docker/docker-23.0.1incompatible' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/golang.org/x/sys-0.5.0' into main
  > Bump github.com/opencontainers/runtime-spec
  > Merge pull request #191 from cloudfoundry/out-of-disk-error-with-jammy
Submodule src/guardian 913b899bc..86f0a7d78:
  > Set container properties before creating container
  > Containers() returns all containers when garden.state is all
  > Merge pull request #364 from cloudfoundry/with-ginkgo-v2
  > go mod tidy && vendor
  > Bump lager to latest on master
  > use typeurl/v2
  > 🔓 dep
  > go mod tidy and vendor
  > go mod tidy
  > go mod tidy
  > Merge pull request #361 from cloudfoundry/dependabot/go_modules/github.com/cloudfoundry/gosigar-1.3.9
  > Merge pull request #363 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.27.4
  > Merge pull request #362 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.7.0
  > Merge pull request #345 from cloudfoundry/dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible
  > Merge pull request #359 from cloudfoundry/unpin-components
  > Update path to remove unneeded bin dir
  > Remove runc pin
  > Add runc to build package
  > go mod tidy
  > Merge pull request #355 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.6.19
Submodule src/idmapper a23279655..390987bf5:
  > Bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1
  > Merge pull request #65 from cloudfoundry/unpin-components
  > Bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
  > Bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4
  > Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.8.3
  > Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0
  > Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1
  > Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0
  > Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1
  > Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0
  > Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0
  > Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1
  > Bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.0
  > Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0
  > Bump github.com/onsi/ginkgo/v2 from 2.1.5 to 2.1.6
  > Bump github.com/onsi/ginkgo/v2 from 2.1.4 to 2.1.5
winkingturtle-vmw pushed a commit that referenced this pull request Apr 10, 2023
bump auction auctioneer bbs buildpackapplifecycle bytefmt cacheddownloader cfdot diego-ssh dockerapplifecycle dockerdriver ecrhelper executor fileserver goshims healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts trace-logger vizzini volman workpool garden grootfs guardian idmapper

Submodule src/code.cloudfoundry.org/auction f4db6c5..20b5e4e:
  > Bump to ginkgo/v2 and lager/v3 (#10)
Submodule src/code.cloudfoundry.org/auctioneer 7b69d26..6757f66:
  > Bump to ginkgo/v2 and lager/v3 (#11)
Submodule src/code.cloudfoundry.org/bbs 952b49b..41bd09f:
  > fix for `go vet` failures (#63)
  > Bump to lager/v3 (remaining)
  > Bump sqldb/helpers + test helpers to lager v3 (#61)
  > Bump to ginkgo/v2
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9bfd77998..b3c0aa499:
  > Merge pull request #61 from cloudfoundry/with-ginkgo-v2
  > Merge pull request #59 from cloudfoundry/develop
Submodule src/code.cloudfoundry.org/cacheddownloader 456a733fa..3de1f8d2e:
  > Bump to ginkgo/v2 and lager/v3 (#23)
Submodule src/code.cloudfoundry.org/cfdot f68fa7f..9c6e1b4:
  > Bump to ginkgo/v2 and lager/v3 (#6)
Submodule src/code.cloudfoundry.org/diego-ssh 0fc4f3a..1003fb5:
  > Bump to ginkgo/v2 and lager/v3 (#47)
Submodule src/code.cloudfoundry.org/dockerapplifecycle 163faed..36aa909:
  > Bump to ginkgo/v2 (#11)
  > Regenerate test certificates
Submodule src/code.cloudfoundry.org/dockerdriver 16e1fe9ba..76bff1bc5:
  > Bump to ginkgo/v2 and lager/v3 (#3)
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/code.cloudfoundry.org/ecrhelper 9a7c7e5..3949c02:
  > Bump to ginkgo/v2 (#2)
Submodule src/code.cloudfoundry.org/executor 1e5a6f1..208a08c:
  > With ginkgo v2 and lager/v3 (#75)
  > Ensure we release info lock when marshaling fails
  > Update garden container logging tags
  > Fix typo in function name
  > Fetch all containers for cleanup
  > Executor releases resources only when a container is successfully deleted
Submodule src/code.cloudfoundry.org/fileserver 11af6ea..f3dfda9:
  > Bump to ginkgo/v2 && lager/v3 (#7)
Submodule src/code.cloudfoundry.org/goshims bb24d2ef7..cf8c6ba6c:
  > Bump golang.org/x/net from 0.7.0 to 0.8.0 (#24)
  > Bump golang.org/x/net from 0.0.0-20200301022130-244492dfa37a to 0.7.0 (#23)
  > Bump github.com/go-sql-driver/mysql from 1.6.0 to 1.7.0 (#22)
  > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#21)
  > Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)" (#20)
  > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)
  > Merge pull request #18 from cloudfoundry/dependabot/add-v2-config-file
  > Merge pull request #17 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.36.0
  > Merge pull request #16 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.35.0
  > Merge pull request #15 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.1
  > Merge pull request #14 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.0
  > Merge pull request #13 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.2
  > Merge pull request #12 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.1
  > Merge pull request #11 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.32.0
  > Merge pull request #10 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.1
  > Merge pull request #9 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.0
  > Merge pull request #8 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.30.0
  > go mod vendor
  > Merge pull request #7 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.29.1
  > 🤖 go mod vendor
  > go get -u all
  > Add gitignore file
  > Convert to go modules
  > Add SetEnv to the command interface
Submodule src/code.cloudfoundry.org/healthcheck d7f787b..7670cbf:
  > Bump to ginkgo/v2 (#9)
Submodule src/code.cloudfoundry.org/inigo 18bab03..3c8b1a8:
  > Bump to ginkgo/v2 & lager/v3 (#25)
Submodule src/code.cloudfoundry.org/localdriver 1b0a47b..0668dcc:
  > Bump to ginkgo/v2 & lager/v3 (#2)
Submodule src/code.cloudfoundry.org/locket 76a930295..5e8522d97:
  > {fake_runner,fake_runner_v2} to be used with (#14)
  > Add BeforeSuite in the right place
  > Fix govet errors
  > Bump to lager v3
  > WIP - upgrading to ginkgo v2+ ginkgomon_v2
Submodule src/code.cloudfoundry.org/operationq da3eb22..4522d08:
  > Bump to ginkgo/v2 (#2)
  > Fix the test for max capacity
  > Ginkgo v2: don't use Done channels
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/code.cloudfoundry.org/rep be8beeb..f627e21:
  > Bump to ginkgo/v2 && lager/v3 (#39)
Submodule src/code.cloudfoundry.org/route-emitter c907cd8..da039b0:
  > Bump to ginkgo/v2 && lager/v3 (#21)
Submodule src/code.cloudfoundry.org/routing-api ff096da8d..2bf566855:
  > Fix ginkgo deprecations with Done channels
  > Fix ginkgo v2 flag deprecation notices
  > Bump to lager v3
  > Convert  to ginkgo v2 + inline the archived trace package
  > Convert to ginkgo v2 + inline the archived trace package
  > ignore .test files in the repo
  > Bump to ginkgo/v2
  > Bump to ginkgo/v2 - WIP
  > Allow uaaclient callers to optionally pass in a protocol via (#30)
Submodule src/code.cloudfoundry.org/routing-info 7d023ecb0..c6998d604:
  > Bump to ginkgo/v2
Submodule src/code.cloudfoundry.org/systemcerts 95ea366d9..5244fcb1b:
  > refactor: rm use of internal/testenv
Submodule src/code.cloudfoundry.org/vizzini a59096109...6474f903a:
  > fix `go vet` failures
  > Bump to ginkgo/v2 && lager/v3
  < Fix one more test using metric tags
Submodule src/code.cloudfoundry.org/volman 4129b31..76091d5:
  > Bump to ginkgo/v2 && lager/v3 (#5)
Submodule src/code.cloudfoundry.org/workpool e8b9128..2e26d5d:
  > Bump to ginkgo/v2 (#2)
  > Update PULL_REQUEST_TEMPLATE.md
  > content change
Submodule src/garden d57de807d..8534099e1:
  > Migrate to lager v3
  > Migrate to ginkgo/v2
  > Bump lager to latest on master
  > Revert "bump ginkgo to v2 and lager to v3"
  > Merge pull request #107 from xtremerui/bump-ginkgo-lager
  > Bump golang.org/x/net from 0.0.0-20210428140749-89ef3d95e781 to 0.7.0
  > Merge pull request #105 from cloudfoundry/unpin-components
  > Merge pull request #103 from ebroberson/ginkgov2-done-channels
Submodule src/grootfs ba02da43d..df476b3ba:
  > Swtch to channels from pool
  > Return to pool xfs mounts that don't cause test pollution
  > Generate 10 mount points for all quota tests
  > Use unique mount directory for each test
  > Merge pull request #197 from cloudfoundry/with-ginkgo-v2
  > go mod tidy && vendor
  > Bump lager to latest on master
  > 🔒 dep
  > Merge pull request #196 from cloudfoundry/unpin-components
  > Bump golang.org/x/sys from 0.5.0 to 0.6.0
  > go mod tidy
  > Merge remote-tracking branch 'local/dependabot/go_modules/code.cloudfoundry.org/lager-2.0.0incompatible' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/containers/image/v5-5.24.2' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/docker/docker-23.0.1incompatible' into main
  > Merge remote-tracking branch 'local/dependabot/go_modules/golang.org/x/sys-0.5.0' into main
  > Bump github.com/opencontainers/runtime-spec
  > Merge pull request #191 from cloudfoundry/out-of-disk-error-with-jammy
Submodule src/guardian 913b899bc..86f0a7d78:
  > Set container properties before creating container
  > Containers() returns all containers when garden.state is all
  > Merge pull request #364 from cloudfoundry/with-ginkgo-v2
  > go mod tidy && vendor
  > Bump lager to latest on master
  > use typeurl/v2
  > 🔓 dep
  > go mod tidy and vendor
  > go mod tidy
  > go mod tidy
  > Merge pull request #361 from cloudfoundry/dependabot/go_modules/github.com/cloudfoundry/gosigar-1.3.9
  > Merge pull request #363 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.27.4
  > Merge pull request #362 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.7.0
  > Merge pull request #345 from cloudfoundry/dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible
  > Merge pull request #359 from cloudfoundry/unpin-components
  > Update path to remove unneeded bin dir
  > Remove runc pin
  > Add runc to build package
  > go mod tidy
  > Merge pull request #355 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.6.19
Submodule src/idmapper a23279655..390987bf5:
  > Bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1
  > Merge pull request #65 from cloudfoundry/unpin-components
  > Bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0
  > Bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4
  > Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.8.3
  > Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0
  > Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1
  > Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0
  > Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1
  > Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0
  > Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0
  > Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1
  > Bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.0
  > Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0
  > Bump github.com/onsi/ginkgo/v2 from 2.1.5 to 2.1.6
  > Bump github.com/onsi/ginkgo/v2 from 2.1.4 to 2.1.5
appruntimeplatform-bot pushed a commit that referenced this pull request Jul 8, 2025
Submodule src/code.cloudfoundry.org/bbs 5ed908e..521c7ab:
  > update naming convention
  > add tests for MultipleActualLRPsByMultipleGuids endpoint
  > add validation
  > get multiple lrps by multiple guids endpoint
  > [RFC0038] icmpv6 support in ASGs (#107)
Submodule src/code.cloudfoundry.org/executor 3192fb1..e1d6469:
  > [RFC0038] Support container IPv6 address and icmpv6 NetOut rules (#112)
Submodule src/garden 90c04595b..d3b7c3a6e:
  > Merge pull request #125 from plamen-bardarov/icmpv6-support-asg
Submodule src/grootfs 014abbef6..0de05f09d:
  > Update go.mod dependencies
  > Update go.mod dependencies
Submodule src/guardian 7fa03efb2..03a2f9c1b:
  > Update go.mod dependencies
  > Update go.mod dependencies
  > Merge pull request #478 from kart2bc/fix-lager-test
  > Update go.mod dependencies
kart2bc pushed a commit to kart2bc/diego-release that referenced this pull request Aug 19, 2025
* icmpv6 support

* add icmpv6 ASG tests

* icmpv6 ASG test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants