Skip to content
This repository was archived by the owner on Jan 21, 2022. It is now read-only.

Conversation

@emalm
Copy link
Contributor

@emalm emalm commented Dec 20, 2016

This change allows jobs to run correctly in garden-runc containers
as well as in the previously supported garden-linux and docker containers.

This change allows jobs to run correctly in garden-runc containers
as well as in the previously supported garden-linux and docker containers.
@cfdreddbot
Copy link

Hey ematpl!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link
Collaborator

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/136408735

The labels on this github issue will be updated when the story is started.

@jaresty
Copy link
Contributor

jaresty commented Dec 27, 2016

@ematpl Can you explain a bit more what is going on here? This is the first time I've seen this code so I'm not sure of the best way to test that it is working properly.

  • What did it used to do, and what is it doing now?
  • What could be affected by this change, and how could I test that those things still function correctly?

Thanks for your help. Please feel free to stop by in person to demonstrate if it's easier than replying in a comment.

@ChunyiLyu ChunyiLyu merged commit 50ade95 into develop Dec 27, 2016
@emalm emalm deleted the generalize-running-in-container-function branch December 27, 2016 19:40
@emalm
Copy link
Contributor Author

emalm commented Dec 27, 2016

Thanks @ChunyiLyu and @jaresty ! Please let me know if you need any more information about the changes in this PR.

@ChunyiLyu
Copy link
Contributor

@ematpl No worries! Jesse filled in the information about this PR. Our bosh-lite successfully deployed and CATs had passed as well. It all looks good :)

@emalm
Copy link
Contributor Author

emalm commented Dec 27, 2016

Awesome, thanks!

emalm added a commit to emalm/capi-release that referenced this pull request Jan 12, 2017
This change allows jobs to run correctly in garden-runc containers as well as in the previously supported garden-linux and docker containers.

See also cloudfoundry-attic/cf-release#1130, cloudfoundry/diego-release#242, cloudfoundry/routing-release#56 + related discussion on https://www.pivotaltracker.com/story/show/135771525.
emalm added a commit to emalm/capi-release that referenced this pull request Jan 12, 2017
This change allows jobs to run correctly in garden-runc containers as well as in the previously supported garden-linux and docker containers.

See also cloudfoundry-attic/cf-release#1130, cloudfoundry/diego-release#242, cloudfoundry/routing-release#56 + related discussion on https://www.pivotaltracker.com/story/show/135771525.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants