stop login console spam #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7aa4794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2059265420/npm-package-wrangler-695You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/695/npm-package-wrangler-695Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2059265420/npm-package-wrangler-695 dev path/to/script.js |
added 7 commits
March 29, 2022 06:33
Partially this involves mocking `open-in-browser.ts`, which I've chosen to mock out in `user.test.ts` rather than `jest.setup.ts` since we might later want to mock it out differently for testing wrangler dev
caass
force-pushed
the
stop-login-console-spam
branch
from
3f94ed2 to
63b5148
Compare
And just disable it for login checks
petebacondarwin
approved these changes
Mar 30, 2022
| @@ -963,6 +979,8 @@ export async function login(props?: LoginProps): Promise<boolean> { | |||
| server.listen(8976); | |||
| }); | |||
|
|
|||
| await openInBrowser(urlToOpen); | |||
There was a problem hiding this comment.
NOTE: moving this here, helps to ensure that the HTTP server that will receive the callback from the OAuth provider is already listening before we try to open the OAuth web page.
Merged
|
Such a good PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user hasn't logged in and then they run a command that needs a login they'll get bounced to the login flow.
The login flow (if completed) would write their shiny new OAuth2 credentials to disk, but wouldn't reload the
in-memory state. This led to issues like #693, where even though the user was logged in on-disk, wrangler
wouldn't be aware of it.
We now update the in-memory login state each time new credentials are written to disk.