-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 BUG: npm start after forced login results in a lot of warnings #693
Comments
Worth noting:
|
Oh!! Haha, we don't re-read the config file once the login has occurred, so we don't realise that it has changed. |
Luckily we even have a helper for that, which was only being used in the tests so far: |
Merged
Merged
petebacondarwin
pushed a commit
that referenced
this issue
Mar 30, 2022
If a user hasn't logged in and then they run a command that needs a login they'll get bounced to the login flow. The login flow (if completed) would write their shiny new OAuth2 credentials to disk, but wouldn't reload the in-memory state. This led to issues like #693, where even though the user was logged in on-disk, wrangler wouldn't be aware of it. We now update the in-memory login state each time new credentials are written to disk.
Repository owner
moved this from Must-have
to Done
in workers-sdk
Mar 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of
Wrangler
are you using?0.0.0-8f7ac7b
What operating system are you using?
Mac
Describe the Bug
I installed wrangler@alpha and then ran an init followed by npm start. I wasn't logged in so I was bounced to the login flow and after I authenticated I got a bunch of terminal spam even though it was a brand new project. Here is my terminal output.
The text was updated successfully, but these errors were encountered: