fix: cleanup after pages dev tests
#678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2549799 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
from
2f70d9c
to
a8193b8
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2027536893/npm-package-wrangler-678You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/678/npm-package-wrangler-678Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2027536893/npm-package-wrangler-678 dev path/to/script.js |
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
from
a8193b8
to
78e11ef
Compare
threepointone
commented
Mar 23, 2022
| console.log(chunk.toString()); | ||
| }); | ||
| }); | ||
|
|
||
| afterAll(() => { | ||
| wranglerProcess.kill(); | ||
| afterAll(async () => { |
There was a problem hiding this comment.
could probably clean this up by using execa here, but I'll leave that for some other time/person
|
oh lol this hangs on windows and ubuntu huh |
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
from
78e11ef
to
a3d2c35
Compare
threepointone
changed the title
pages dev testspages dev tests
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
from
a3d2c35
to
5cad8f3
Compare
threepointone
changed the title
pages dev testspages dev tests
|
Aight, looks like forceExit is still necessary for windows/ubuntu. |
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
2 times, most recently
from
c2f0c6c
to
1ee1c91
Compare
threepointone
force-pushed
the
cleanup-pages-dev-tests
branch
from
1ee1c91
to
2549799
Compare
threepointone
commented
Mar 23, 2022
| @@ -27,6 +27,7 @@ const EXIT = (message?: string, code?: number) => { | |||
| if (message) console.log(message); | |||
| if (code) process.exitCode = code; | |||
| EXIT_CALLBACKS.forEach((callback) => callback()); | |||
| RUNNING_BUILDERS.forEach((builder) => builder.stop?.()); | |||
There was a problem hiding this comment.
This cleans up hanging esbuild processes
GregBrimble
approved these changes
Mar 23, 2022
|
🤞 |
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
With #656, the Queues dispatcher is now implemented as part of the broker Durable Object. We no longer send message batches directly from Node.js, so can remove queue handling from the entry worker. Note the magic proxy enqueues messages through queue producer bindings like regular workers, so never used this endpoint directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.
Fixes #397
Fixes #618
(fyi this does NOT cleanup the occasional flake with the remix test where the text doesn't render)