Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pages dev integration tests leave port open #618

Closed
GregBrimble opened this issue Mar 16, 2022 · 5 comments · Fixed by #678 or #679
Closed

pages dev integration tests leave port open #618

GregBrimble opened this issue Mar 16, 2022 · 5 comments · Fixed by #678 or #679
Labels
maintenance Maintenance task pages Relating to Pages

Comments

@GregBrimble
Copy link
Member

GregBrimble commented Mar 16, 2022 •
edited
Loading

Super annoying. Let's ensure we close them cleanly.

  • example-pages-functions-app
  • example-remix-pages-app
@GregBrimble GregBrimble added the maintenance Maintenance task label Mar 16, 2022
@threepointone
Copy link
Contributor

#397

@GregBrimble
Copy link
Member Author

Ah thanks. I looked but couldn't find an open issue.

@threepointone
Copy link
Contributor

It's related, but not the same issue tbf. Could you drop a note there that ports are also being left open?

@GregBrimble GregBrimble mentioned this issue Mar 16, 2022
Closed
@threepointone threepointone reopened this Mar 17, 2022
@threepointone threepointone added bug pages Relating to Pages labels Mar 17, 2022
@GregBrimble GregBrimble mentioned this issue Mar 22, 2022
Merged
@threepointone threepointone reopened this Mar 23, 2022
@threepointone
Copy link
Contributor

This still happens 😢

@threepointone
Copy link
Contributor

working on this, I think I have a lead

threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
a8193b8 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGTERM/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
@threepointone threepointone mentioned this issue Mar 23, 2022
Merged
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
78e11ef 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
a3d2c35 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. This also lets us remove `--forceExit` from the test runner calls. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
5cad8f3 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
c2f0c6c 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397 and #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
1ee1c91 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #618
threepointone added a commit that referenced this issue Mar 23, 2022
@threepointone
fix: cleanup after pages dev tests
2549799 
We weren't killing the process started by wrangler whenever its parent was killed. This fix is to listen on SIGINT/SIGTERM and kill that process. I also did some minor configuration cleanups.

Fixes #397
Fixes #618
@github-actions github-actions bot mentioned this issue Mar 23, 2022
Merged
mrbbot added a commit that referenced this issue Oct 31, 2023
@mrbbot
Update API docs with routes, queue*, https*, and upstream (#618)
e91f825 
* Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Update API docs with routes, queue*, https*, and upstream (#618)
b03ba61 
* Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Update API docs with routes, queue*, https*, and upstream (#618)
2bd894c 
* Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`
mrbbot added a commit that referenced this issue Nov 1, 2023
@mrbbot
Update API docs with routes, queue*, https*, and upstream (#618)
0ac4073 
* Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`

* fixup! Update API docs with `routes`, `queue*`, `https*`, and `upstream`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Maintenance task pages Relating to Pages
Projects
None yet
Milestone
No milestone
2 participants
@threepointone @GregBrimble