feat: secrets + environments #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff8ea80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1892950702/npm-package-wrangler-523You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/523/npm-package-wrangler-523Or you can use npx https://prerelease-registry.developers.workers.dev/runs/1892950702/npm-package-wrangler-523 dev path/to/script.js |
threepointone
commented
Feb 24, 2022
| await fetchResult( | ||
| `/accounts/${config.account_id}/workers/scripts/${scriptName}`, | ||
| !args["legacy-env"] && args.env |
There was a problem hiding this comment.
filed #524 to write tests for this codepath, looks like I missed it last time around
This implements environment support for `wrangler secret` (both legacy and services). We now consistently generate the right script name across commands with the `getScriptName()` helper.
threepointone
force-pushed
the
secret-envs
branch
from
41bbf9a
to
ff8ea80
Compare
1 task
|
I tested this pretty decently, and it works ok. There's one bug I discovered with the api, I'll file that internally. Landing this. |
Merged
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements environment support for
wrangler secret(both legacy and services). We now consistently generate the right script name across commands with thegetScriptName()helper.