chore: add workers-chat-demo #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the `workers-chat-demo` from https://github.com/cloudflare/workers-chat-demo as an example app into our monorepo. It has some modifications, documted at the top of its `README.md`. Of note, you'll note that this _doesn't_ work with wrangler. Landing this so we can debug and have a shared reference that we need to get to work.
|
|
A wrangler prerelease is available for testing. You can install it in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/1852676174/wranglerOr you can try developing a worker directly with: npx https://prerelease-registry.developers.workers.dev/runs/1852676174/wrangler dev path/to/script.js |
|
Landing this. |
This was referenced Sep 1, 2023
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
Previously, the `MF-Custom-Service` header was including on the `request` parameter passed to custom service functions. This usually wasn't a problem, but if the request ever made it back to the loopback server (e.g. via `caches.default.put(request, ...)`), it would be forwarded back to the custom service instead of the appropriate plugin router.
mrbbot
added a commit
that referenced
this pull request
Oct 31, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Previously, the `MF-Custom-Service` header was including on the `request` parameter passed to custom service functions. This usually wasn't a problem, but if the request ever made it back to the loopback server (e.g. via `caches.default.put(request, ...)`), it would be forwarded back to the custom service instead of the appropriate plugin router.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Previously, the `MF-Custom-Service` header was including on the `request` parameter passed to custom service functions. This usually wasn't a problem, but if the request ever made it back to the loopback server (e.g. via `caches.default.put(request, ...)`), it would be forwarded back to the custom service instead of the appropriate plugin router.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Previously, the `MF-Custom-Service` header was including on the `request` parameter passed to custom service functions. This usually wasn't a problem, but if the request ever made it back to the loopback server (e.g. via `caches.default.put(request, ...)`), it would be forwarded back to the custom service instead of the appropriate plugin router.
mrbbot
added a commit
that referenced
this pull request
Nov 1, 2023
Similar to #475, we weren't deleting the `MF-Original-URL` header from incoming requests, leading to incorrect URLs in the loopback server when the incoming request was passed-through as the cache key. Tests also needed to be updated as the storage location is now based off the actual URL passed to `dispatchFetch()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
workers-chat-demofrom https://github.com/cloudflare/workers-chat-demo as an example app into our monorepo. It has some modifications, documted at the top of itsREADME.md.Of note, you'll note that this doesn't work with wrangler. Landing this so we can debug and have a shared reference that we need to get to work.