fix: do not crash in wrangler dev if user has multiple accounts
#1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60fcf59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2542396946/npm-package-wrangler-1293You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1293/npm-package-wrangler-1293Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2542396946/npm-package-wrangler-1293 dev path/to/script.js |
petebacondarwin
force-pushed
the
account-selector-dev
branch
4 times, most recently
from
2476264
to
2122d48
Compare
petebacondarwin
force-pushed
the
account-selector-dev
branch
4 times, most recently
from
a04ed82
to
10255ea
Compare
threepointone
approved these changes
Jun 21, 2022
petebacondarwin
force-pushed
the
account-selector-dev
branch
5 times, most recently
from
205b5f6
to
d5b5ba1
Compare
When a user has multiple accounts we show a prompt to allow the user to select which they should use. This was broken in wrangler dev as we were trying to start a new ink.js app (to show the prompt) from inside a running ink.js app (the UI for wrangler dev). This fix refactors the ChooseAccount component so that it can be used directly within another component. Fixes cloudflare#1258
The previous tests for non-interactive only checked the stdin.isTTY, but you can have scenarios where the stdin is interactive but the stdout is not. For example when writing the output of a `kv:key get` command to a file. We now check that both stdin and stdout are interactive before trying to interact with the user.
petebacondarwin
force-pushed
the
account-selector-dev
branch
from
d5b5ba1
to
60fcf59
Compare
|
OK - here goes! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has multiple accounts we show a prompt to allow the user to select which they should use.
This was broken in
wrangler devas we were trying to start a new ink.js app (to show the prompt)from inside a running ink.js app (the UI for
wrangler dev).This fix refactors the
ChooseAccountcomponent so that it can be used directly within another component.Fixes #1258