Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not crash in wrangler dev if user has multiple accounts #1293

Merged
merged 11 commits into from
Jun 22, 2022
Merged

fix: do not crash in wrangler dev if user has multiple accounts #1293

merged 11 commits into from
Jun 22, 2022

Commits on Jun 22, 2022

  1. move generate helpers to user directory

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    04ac454 View commit details
    Browse the repository at this point in the history

  2. don't report cache usage when only writing to the cache

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    685a5aa View commit details
    Browse the repository at this point in the history

  3. Do not patch the console when using ink to render a simple static output

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    7073409 View commit details
    Browse the repository at this point in the history

  4. Mock out setEncoding() when mocking process.stdin

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    9cd6000 View commit details
    Browse the repository at this point in the history

  5. capture the last std.write() call not the first

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    ac6add3 View commit details
    Browse the repository at this point in the history

  6. move user.tsx into the user directory

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b024898 View commit details
    Browse the repository at this point in the history

  7. Move env vars getters into own file

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    2b71790 View commit details
    Browse the repository at this point in the history

  8. Use common GET memberships mock in tests

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    7f7a93c View commit details
    Browse the repository at this point in the history

  9. fix: do not crash in wrangler dev if user has multiple accounts 

    When a user has multiple accounts we show a prompt to allow the user to select which they should use.
This was broken in wrangler dev as we were trying to start a new ink.js app (to show the prompt)
from inside a running ink.js app (the UI for wrangler dev).

This fix refactors the ChooseAccount component so that it can be used directly within another component.

Fixes cloudflare#1258
    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    6430838 View commit details
    Browse the repository at this point in the history

  10. fixup! fix: do not crash in wrangler dev if user has multiple accounts

    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    89e4a33 View commit details
    Browse the repository at this point in the history

  11. fix: do not hang waiting for account choice when in non-interactive mode 

    The previous tests for non-interactive only checked the stdin.isTTY, but
you can have scenarios where the stdin is interactive but the stdout is not.
For example when writing the output of a `kv:key get` command to a file.

We now check that both stdin and stdout are interactive before trying to
interact with the user.
    @petebacondarwin
    petebacondarwin committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    60fcf59 View commit details
    Browse the repository at this point in the history