Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bind a durable object by environment #1019

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

threepointone
Copy link
Contributor

For durable objects, instead of just { name, class_name, script_name}, this lets you bind by environment as well, like so { name, class_name, script_name, environment }.

Fixes #996

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

🦋 Changeset detected

Latest commit: d37613b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2331924480/npm-package-wrangler-1019

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1019/npm-package-wrangler-1019

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2331924480/npm-package-wrangler-1019 dev path/to/script.js

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original issue you say:

This should probably only work with service environments (with legacy, you'd add - to the script_name)

I don't think this has been taken into account here, right? Should we add a check for legacy env?

packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
packages/wrangler/src/__tests__/configuration.test.ts Outdated Show resolved Hide resolved
For durable objects, instead of just `{ name, class_name, script_name}`, this lets you bind by environment as well, like so `{ name, class_name, script_name, environment }`.

Fixes #996
@threepointone
Copy link
Contributor Author

So we have docs that show you how to bind to workers with "legacy" environments https://developers.cloudflare.com/workers/learning/using-durable-objects/#configuring-durable-object-bindings. There's maybe something we can do here where we specify legacy: true and automatically add -<env name> to the worker name, but I dunno how I feel about that just yet. I figured we'd land this first and work on that later when it's asked for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: bind to an external script's durable object by environment
2 participants