-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bind a durable object by environment #1019
Conversation
🦋 Changeset detectedLatest commit: d37613b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2331924480/npm-package-wrangler-1019 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/1019/npm-package-wrangler-1019 Or you can use npx https://prerelease-registry.developers.workers.dev/runs/2331924480/npm-package-wrangler-1019 dev path/to/script.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the original issue you say:
This should probably only work with service environments (with legacy, you'd add - to the script_name)
I don't think this has been taken into account here, right? Should we add a check for legacy env?
For durable objects, instead of just `{ name, class_name, script_name}`, this lets you bind by environment as well, like so `{ name, class_name, script_name, environment }`. Fixes #996
b781bcc
to
d37613b
Compare
So we have docs that show you how to bind to workers with "legacy" environments https://developers.cloudflare.com/workers/learning/using-durable-objects/#configuring-durable-object-bindings. There's maybe something we can do here where we specify |
For durable objects, instead of just
{ name, class_name, script_name}
, this lets you bind by environment as well, like so{ name, class_name, script_name, environment }
.Fixes #996