Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bind to an external script's durable object by environment #996

Closed
threepointone opened this issue May 13, 2022 · 0 comments · Fixed by #1019 or #1025
Closed

feat: bind to an external script's durable object by environment #996

threepointone opened this issue May 13, 2022 · 0 comments · Fixed by #1019 or #1025
Assignees
@threepointone
Labels
enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

A durable object binding (external) looks like this { name, class_name, script_name}, but should also optionally accept environment so as to be { name, class_name, script_name, environment }. This should probably only work with service environments (with legacy, you'd add -<env> to the script_name)
@threepointone threepointone added the enhancement New feature or request label May 13, 2022
@threepointone threepointone added this to the 2.1 milestone May 13, 2022
@petebacondarwin petebacondarwin modified the milestones: Selected for development, Backlog May 15, 2022
@petebacondarwin petebacondarwin moved this to Backlog in workers-sdk May 15, 2022
@petebacondarwin petebacondarwin removed this from the Backlog milestone May 15, 2022
@threepointone threepointone moved this from Backlog to Selected for development in workers-sdk May 16, 2022
@threepointone threepointone self-assigned this May 16, 2022
@threepointone threepointone moved this from Selected for development to In Progress in workers-sdk May 16, 2022
threepointone added a commit that referenced this issue May 16, 2022
@threepointone
feat: bind a durable object by environment
b781bcc 
For durable objects, instead of just `{ name, class_name, script_name}`, this lets you bind by environment as well, like so `{ name, class_name, script_name, environment }`.

Fixes #996
@threepointone threepointone mentioned this issue May 16, 2022
Merged
@threepointone threepointone moved this from In Progress to In Review in workers-sdk May 16, 2022
threepointone added a commit that referenced this issue May 16, 2022
@threepointone
feat: bind a durable object by environment
d37613b 
For durable objects, instead of just `{ name, class_name, script_name}`, this lets you bind by environment as well, like so `{ name, class_name, script_name, environment }`.

Fixes #996
Repository owner moved this from In Review to Done in workers-sdk May 16, 2022
threepointone added a commit that referenced this issue May 16, 2022
@threepointone
feat: bind a durable object by environment (#1019)
5816eba 
For durable objects, instead of just `{ name, class_name, script_name}`, this lets you bind by environment as well, like so `{ name, class_name, script_name, environment }`.

Fixes #996
@github-actions github-actions bot mentioned this issue May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@threepointone threepointone

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@petebacondarwin @threepointone