Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive pages publish prompts #891

Merged
merged 7 commits into from
May 4, 2022

Conversation

GregBrimble
Copy link
Member

Adds interactive prompts for the 'wrangler pages publish' and related commands.

Additionally, those commands now read from node_modules/.cache/wrangler/pages.json to persist users' account IDs and project names (#854). Fixes #874.

@GregBrimble GregBrimble added the pages Relating to Pages label May 4, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 4, 2022

🦋 Changeset detected

Latest commit: 72bf28d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2269609799/npm-package-wrangler-891

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/891/npm-package-wrangler-891

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2269609799/npm-package-wrangler-891 dev path/to/script.js

@GregBrimble GregBrimble force-pushed the interactive-pages-publish-prompts branch 2 times, most recently from f6d8fbe to 3753973 Compare May 4, 2022 11:57
@GregBrimble GregBrimble force-pushed the interactive-pages-publish-prompts branch from 3753973 to 72bf28d Compare May 4, 2022 12:01
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

packages/wrangler/src/pages.tsx Show resolved Hide resolved
packages/wrangler/src/pages.tsx Show resolved Hide resolved
packages/wrangler/src/pages.tsx Show resolved Hide resolved
packages/wrangler/src/config-cache.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Relating to Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove pages code that reads from wrangler.toml
2 participants