Skip to content

update Next on Workers template to use 1.0.0-beta.0#8765

Merged
petebacondarwin merged 4 commits into
mainfrom
vicb/nextc3
Apr 4, 2025
Merged

update Next on Workers template to use 1.0.0-beta.0#8765
petebacondarwin merged 4 commits into
mainfrom
vicb/nextc3

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Apr 3, 2025


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: Already tested - tested pnpm locally
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Not affected
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: version bump
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: template update

@vicb vicb requested a review from a team April 3, 2025 07:35
@vicb vicb requested a review from a team as a code owner April 3, 2025 07:35
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 62e8f42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 3, 2025
@vicb vicb added the ci:c3-e2e Run C3 E2E tests on a pull request label Apr 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-wrangler-8765

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8765/npm-package-wrangler-8765

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-wrangler-8765 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-workers-bindings-extension-8765 -O ./cloudflare-workers-bindings-extension.0.0.0-vb4b0582f3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb4b0582f3.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-create-cloudflare-8765 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-kv-asset-handler-8765

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-miniflare-8765

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-pages-shared-8765

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-unenv-preset-8765

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-vite-plugin-8765

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-vitest-pool-workers-8765

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-workers-editor-shared-8765

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-workers-shared-8765

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14259980649/npm-package-cloudflare-workflows-shared-8765

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.7.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.2
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C3 e2e tests for open next are currently all disabled. See https://github.com/cloudflare/workers-sdk/blob/main/packages/create-cloudflare/e2e-tests/frameworks/framework-test-config.ts#L427-L432

We should try to re-enable those in this PR if possible.

The yarn and bun have been disabled forever but I had to disable pnpm yesterday in order to get the tests to pass for the release.

Perhaps moving to opennextjs-cloudflare build && opennextjs-cloudflare preview will help?

Comment thread packages/create-cloudflare/templates/next/workers/templates/wrangler.jsonc Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Apr 3, 2025
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk Apr 3, 2025
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Apr 4, 2025

Rebased in the last push

@petebacondarwin petebacondarwin merged commit 95fc93f into main Apr 4, 2025
@petebacondarwin petebacondarwin deleted the vicb/nextc3 branch April 4, 2025 09:29
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 4, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:c3-e2e Run C3 E2E tests on a pull request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants