Skip to content

IGLOO-45 replace underscore with slashes in catalog URI#8763

Merged
petebacondarwin merged 2 commits into
cloudflare:mainfrom
garrettgu10:ggu/igloo-underscore-to-slash
Apr 4, 2025
Merged

IGLOO-45 replace underscore with slashes in catalog URI#8763
petebacondarwin merged 2 commits into
cloudflare:mainfrom
garrettgu10:ggu/igloo-underscore-to-slash

Conversation

@garrettgu10
Copy link
Copy Markdown
Contributor

We're updating the backend service to use slashes in the catalog URI instead of underscores to separate account id and bucket name. This PR updates the frontend to match that.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: we don't run E2E tests for this beta service yet
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: documentation isn't out yet
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: we are not supporting V3

@garrettgu10 garrettgu10 requested a review from a team as a code owner April 2, 2025 20:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 5e991cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@garrettgu10 garrettgu10 force-pushed the ggu/igloo-underscore-to-slash branch from 3d29353 to a9e8dee Compare April 2, 2025 20:40
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-wrangler-8763

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8763/npm-package-wrangler-8763

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-wrangler-8763 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-workers-bindings-extension-8763 -O ./cloudflare-workers-bindings-extension.0.0.0-vb28bff390.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb28bff390.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-create-cloudflare-8763 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-kv-asset-handler-8763

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-miniflare-8763

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-pages-shared-8763

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-unenv-preset-8763

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-vite-plugin-8763

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-vitest-pool-workers-8763

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-workers-editor-shared-8763

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-workers-shared-8763

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262383312/npm-package-cloudflare-workflows-shared-8763

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.7.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.2
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@garrettgu10 garrettgu10 force-pushed the ggu/igloo-underscore-to-slash branch from a9e8dee to fcf8950 Compare April 3, 2025 19:24
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 3, 2025
@garrettgu10 garrettgu10 force-pushed the ggu/igloo-underscore-to-slash branch from 648086c to a1b89d5 Compare April 3, 2025 20:00
@petebacondarwin petebacondarwin force-pushed the ggu/igloo-underscore-to-slash branch from a1b89d5 to 5e991cd Compare April 4, 2025 09:31
@petebacondarwin petebacondarwin merged commit 2650fd3 into cloudflare:main Apr 4, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 4, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Apr 4, 2025
@holopin-bot
Copy link
Copy Markdown

holopin-bot Bot commented Apr 4, 2025

Congratulations @garrettgu10, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm92oj6lu58760cjok30nuhej

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants