Skip to content

[miniflare] fix: make sure that miniflare#setOptions allows the update of inspector ports#8747

Merged
petebacondarwin merged 6 commits into
mainfrom
dario/miniflare-inspector-port-set-options-fix
Apr 4, 2025
Merged

[miniflare] fix: make sure that miniflare#setOptions allows the update of inspector ports#8747
petebacondarwin merged 6 commits into
mainfrom
dario/miniflare-inspector-port-set-options-fix

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 1, 2025

Currently if I use an inspectorPort in a miniflare instance and then try to change such
port via setOptions such change is not actually applied, this PR fixes that


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix of an undocumented feature
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: this is a bugfix of a miniflare feature not used by wrangler v3

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner April 1, 2025 11:43
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 260babed5399b8262e457b70e2386c4d90c5d621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dario-piotrowicz dario-piotrowicz added the ci:e2e Run wrangler + vite-plugin E2E tests on a pull request label Apr 1, 2025
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 1, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/miniflare-inspector-port-set-options-fix branch from 897a5fb to 1dabcc3 Compare April 1, 2025 11:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-wrangler-8747

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8747/npm-package-wrangler-8747

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-wrangler-8747 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-workers-bindings-extension-8747 -O ./cloudflare-workers-bindings-extension.0.0.0-v8bb1e6b12.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8bb1e6b12.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-create-cloudflare-8747 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-kv-asset-handler-8747

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-miniflare-8747

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-pages-shared-8747

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-unenv-preset-8747

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-vite-plugin-8747

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-vitest-pool-workers-8747

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-workers-editor-shared-8747

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-workers-shared-8747

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14262708012/npm-package-cloudflare-workflows-shared-8747

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@4.7.1 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250321.2
workerd 1.20250321.0 1.20250321.0
workerd --version 1.20250321.0 2025-03-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@dario-piotrowicz dario-piotrowicz added the package:miniflare Relating to Miniflare label Apr 1, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/miniflare-inspector-port-set-options-fix branch 2 times, most recently from a967b9f to da04f48 Compare April 1, 2025 16:28
Comment thread packages/miniflare/src/plugins/core/inspector-proxy/inspector-proxy-controller.ts Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Apr 3, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/miniflare-inspector-port-set-options-fix branch from da04f48 to 260babe Compare April 3, 2025 16:30
@dario-piotrowicz dario-piotrowicz force-pushed the dario/miniflare-inspector-port-set-options-fix branch from 260babe to b6f8d11 Compare April 4, 2025 09:50
@petebacondarwin petebacondarwin merged commit 0a401d0 into main Apr 4, 2025
@petebacondarwin petebacondarwin deleted the dario/miniflare-inspector-port-set-options-fix branch April 4, 2025 11:19
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 4, 2025
@workers-devprod workers-devprod mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request package:miniflare Relating to Miniflare

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants