Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Durable Objects transfer migration validation #7785

Merged

Conversation

joshthoward
Copy link
Contributor

@joshthoward joshthoward commented Jan 15, 2025

Durable Objects transfer migration validation was previously warning when transfer migrations were specified.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Covered by included tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Addresses a bug in a feature no one uses :P

@joshthoward joshthoward requested a review from a team as a code owner January 15, 2025 20:00
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: a38223d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 15, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-wrangler-7785

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7785/npm-package-wrangler-7785

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-wrangler-7785 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-workers-bindings-extension-7785 -O ./cloudflare-workers-bindings-extension.0.0.0-vb7fd4b587.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb7fd4b587.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-create-cloudflare-7785 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-kv-asset-handler-7785

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-miniflare-7785

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-pages-shared-7785

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-unenv-preset-7785

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-vitest-pool-workers-7785

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-workers-editor-shared-7785

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-workers-shared-7785

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12835275487/npm-package-cloudflare-workflows-shared-7785

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@joshthoward joshthoward force-pushed the joshthoward/fix-do-transfer-migration-validation branch 3 times, most recently from 24089f2 to 1fb67b8 Compare January 17, 2025 19:02
@joshthoward joshthoward force-pushed the joshthoward/fix-do-transfer-migration-validation branch from 1fb67b8 to a38223d Compare January 17, 2025 19:06
Copy link

@simonha9 simonha9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some more explanation in the PR description for posterity?

@joshthoward
Copy link
Contributor Author

Could you add some more explanation in the PR description for posterity?

Done!

@CarmenPopoviciu CarmenPopoviciu merged commit cccfe51 into main Jan 21, 2025
30 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the joshthoward/fix-do-transfer-migration-validation branch January 21, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants