Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sentry Error Filtering #772

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Apr 8, 2022

fix: We want to prevent any user created code from sending Events to Sentry,
which can be captured by uncaughtExceptionMonitor listener.
Miniflare code can run user code on the same process as Wrangler, so we want to return null
if "@miniflare" is present in the Event frames.

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2022

🦋 Changeset detected

Latest commit: 1004c70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/runs/2150908543/npm-package-wrangler-772

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.developers.workers.dev/prs/772/npm-package-wrangler-772

Or you can use npx with this latest build directly:

npx https://prerelease-registry.developers.workers.dev/runs/2150908543/npm-package-wrangler-772 dev path/to/script.js

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should have a changeset, I think

packages/wrangler/src/reporting.ts Show resolved Hide resolved
@JacobMGEvans JacobMGEvans force-pushed the sentry-ignore-miniflare branch 3 times, most recently from 43c9333 to e8d1a8c Compare April 11, 2022 20:07
@petebacondarwin petebacondarwin merged commit a852e32 into main Apr 12, 2022
@petebacondarwin petebacondarwin deleted the sentry-ignore-miniflare branch April 12, 2022 19:48
@github-actions github-actions bot mentioned this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants