Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include the top level Worker name in the parsed config structure #7703

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

petebacondarwin
Copy link
Contributor

Fixes #0000

Related flarelabs-net/vite-plugin-cloudflare#29


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no external change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@petebacondarwin petebacondarwin requested review from a team as code owners January 8, 2025 17:05
Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 9f99b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin force-pushed the pbd/add-top-level-name-config branch from 9f254dc to 58e8338 Compare January 8, 2025 17:06
Copy link
Contributor

github-actions bot commented Jan 8, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-wrangler-7703

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7703/npm-package-wrangler-7703

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-wrangler-7703 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-workers-bindings-extension-7703 -O ./cloudflare-workers-bindings-extension.0.0.0-v5818598a5.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5818598a5.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-create-cloudflare-7703 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-kv-asset-handler-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-miniflare-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-pages-shared-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-unenv-preset-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-vitest-pool-workers-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-workers-editor-shared-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-workers-shared-7703
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12677746624/npm-package-cloudflare-workflows-shared-7703

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.0
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@jamesopstad jamesopstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@petebacondarwin petebacondarwin force-pushed the pbd/add-top-level-name-config branch from 58e8338 to 9f99b5a Compare January 8, 2025 19:35
@petebacondarwin petebacondarwin merged commit e771fe9 into main Jan 8, 2025
29 checks passed
@petebacondarwin petebacondarwin deleted the pbd/add-top-level-name-config branch January 8, 2025 19:52
@workers-devprod workers-devprod mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants