feat: add support for custom unenv resolve path #7522

vicb · 2024-12-11T15:24:32Z

We are moving the unenv preset to this repo.

We will need to be able to test the version that is package with wrangler as well as the dev version. We can do that by passing the path to the dev version in the added env var.

/cc @pi0

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: tested locally
E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: internal use

changeset-bot · 2024-12-11T15:24:36Z

🦋 Changeset detected

Latest commit: 37aeba8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-12-11T15:28:26Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-wrangler-7522

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7522/npm-package-wrangler-7522

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-wrangler-7522 dev path/to/script.js

Additional artifacts:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-workers-bindings-extension-7522 -O ./cloudflare-workers-bindings-extension.0.0.0-v638d96862.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v638d96862.vsix

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-create-cloudflare-7522 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-kv-asset-handler-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-miniflare-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-pages-shared-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-vitest-pool-workers-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-workers-editor-shared-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-workers-shared-7522

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12370972522/npm-package-cloudflare-workflows-shared-7522

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20241205.0
`workerd`	1.20241205.0	1.20241205.0
`workerd --version`	1.20241205.0	2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts

pi0 · 2024-12-17T09:10:58Z

LGTM! Small point: It is technically UNENV_RESOLVE_PATHS not specific to preset paths only 😄

petebacondarwin · 2024-12-17T09:58:44Z

.changeset/fluffy-eggs-film.md

+
+feat(wrangler): allow overriding the unenv preset paths
+
+By default wrangler uses the unenv preset installed via package.json.


Can we clarify this statement. Which package.json are we referring to here? Is it the user's one or the one inside the wrangler package?

I updated the description, PTAL.

packages/wrangler/src/environment-variables/misc-variables.ts

petebacondarwin · 2024-12-17T10:03:13Z

.changeset/fluffy-eggs-film.md

+
+By default wrangler uses the unenv preset installed via package.json.
+
+Setting `WRANGLER_UNENV_RESOLVE_PATHS` allow to use a local version of the preset.


I find this naming a bit confusing. I think that we are only using this path to resolve from imports like unenv/foo/bar to some absolute path, right? It doesn't affect other imports? Are we really just providing custom paths to the unenv package? Is there some other use for thes paths? If not, then I would expect this to be more like WRANGLER_UNENV_PACKAGE_PATH.

The paths are used when unenv resolve the absolute paths.

The module specifiers could be unenv/... or @cloudflare/unenv-preset/...

I like "RESOLVE_PATHS" because it matches require.resolve(id, { paths }) but happy to change if you have strong feeling on this one.

Introduce `WRANGLER_UNENV_RESOLVE_PATHS` to specify a custom root paths for unenv.

Co-authored-by: Pete Bacon Darwin <[email protected]>

This reverts commit 6403e41.

* Revert "feat: add support for custom unenv resolve path (#7522)" This reverts commit 6403e41. * Create thick-ties-glow.md * Revert "chore(wrangler): update unenv dependency version (#7541)" This reverts commit ca9410a. * fix lockfile

feat(wrangler): add support for custom unenv resolve path Introduce `WRANGLER_UNENV_RESOLVE_PATHS` to specify resolve paths for unenv. Co-authored-by: Pete Bacon Darwin <[email protected]>

* Revert "feat: add support for custom unenv resolve path (#7522)" This reverts commit 6403e41. * Create thick-ties-glow.md * Revert "chore(wrangler): update unenv dependency version (#7541)" This reverts commit ca9410a. * fix lockfile

vicb requested a review from a team as a code owner December 11, 2024 15:24

vicb requested a review from petebacondarwin December 11, 2024 15:25

petebacondarwin requested changes Dec 11, 2024

View reviewed changes

packages/wrangler/src/deployment-bundle/esbuild-plugins/hybrid-nodejs-compat.ts Outdated Show resolved Hide resolved

vicb marked this pull request as draft December 11, 2024 17:04

vicb requested a review from petebacondarwin December 16, 2024 10:27

vicb force-pushed the unenv-preset-path branch from 5a39e9e to 20bb308 Compare December 17, 2024 08:53

vicb added the e2e Run e2e tests on a PR label Dec 17, 2024

vicb marked this pull request as ready for review December 17, 2024 08:54

vicb requested a review from pi0 December 17, 2024 08:54

vicb force-pushed the unenv-preset-path branch from 8a85559 to 3023c61 Compare December 17, 2024 09:28

vicb changed the title ~~feat: add support for custom unenv preset path~~ feat: add support for custom unenv resolve path Dec 17, 2024

vicb force-pushed the unenv-preset-path branch from 3023c61 to 2e013e1 Compare December 17, 2024 09:49

petebacondarwin reviewed Dec 17, 2024

View reviewed changes

vicb and others added 5 commits December 17, 2024 11:16

feat: add support for custom unenv resolve path

8ba1940

Introduce `WRANGLER_UNENV_RESOLVE_PATHS` to specify a custom root paths for unenv.

fixup! preset -> resolve

43c0201

fixup! +s

2e922d6

Update packages/wrangler/src/environment-variables/misc-variables.ts

a9e4baa

Co-authored-by: Pete Bacon Darwin <[email protected]>

fixup! changeset

37aeba8

vicb force-pushed the unenv-preset-path branch from 47a73e3 to 37aeba8 Compare December 17, 2024 10:20

vicb requested a review from petebacondarwin December 17, 2024 10:21

petebacondarwin approved these changes Dec 17, 2024

View reviewed changes

vicb merged commit 6403e41 into main Dec 17, 2024
31 checks passed

vicb deleted the unenv-preset-path branch December 17, 2024 12:08

workers-devprod mentioned this pull request Dec 17, 2024

Version Packages #7567

Merged

vicb mentioned this pull request Dec 18, 2024

Test: Add tests to @cloudflate/unenv-preset #7579

Open

penalosa added a commit that referenced this pull request Dec 18, 2024

Revert "feat: add support for custom unenv resolve path (#7522)"

ac5d753

This reverts commit 6403e41.

penalosa mentioned this pull request Dec 18, 2024

Revert "feat: add support for custom unenv resolve path" #7583

Merged

vicb mentioned this pull request Jan 7, 2025

test(wrangler): allow overriding the unenv preset #7685

Merged

9 tasks

vicb mentioned this pull request Jan 15, 2025

chore(wrangler): use the unenv preset from @cloudflare/unenv-preset #7720

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for custom unenv resolve path #7522

feat: add support for custom unenv resolve path #7522

vicb commented Dec 11, 2024 •

edited

Loading

changeset-bot bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

pi0 commented Dec 17, 2024

petebacondarwin Dec 17, 2024

vicb Dec 17, 2024 •

edited

Loading

petebacondarwin Dec 17, 2024

vicb Dec 17, 2024


		feat(wrangler): allow overriding the unenv preset paths

		By default wrangler uses the unenv preset installed via package.json.


		By default wrangler uses the unenv preset installed via package.json.

		Setting `WRANGLER_UNENV_RESOLVE_PATHS` allow to use a local version of the preset.

feat: add support for custom unenv resolve path #7522

feat: add support for custom unenv resolve path #7522

Conversation

vicb commented Dec 11, 2024 • edited Loading

changeset-bot bot commented Dec 11, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Dec 11, 2024 • edited Loading

pi0 commented Dec 17, 2024

petebacondarwin Dec 17, 2024

Choose a reason for hiding this comment

vicb Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

petebacondarwin Dec 17, 2024

Choose a reason for hiding this comment

vicb Dec 17, 2024

Choose a reason for hiding this comment

vicb commented Dec 11, 2024 •

edited

Loading

changeset-bot bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

vicb Dec 17, 2024 •

edited

Loading