Add default image for cloudchamber create #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c8e9562 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-wrangler-7308You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7308/npm-package-wrangler-7308Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-wrangler-7308 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-create-cloudflare-7308 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-kv-asset-handler-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-miniflare-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-pages-shared-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-vitest-pool-workers-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-workers-editor-shared-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-workers-shared-7308npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11976501160/npm-package-cloudflare-workflows-shared-7308Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
gpanders
force-pushed
the
ganders/CC-4280
branch
from
bf2e6b0
to
faf8e56
Compare
gabivlj
approved these changes
Nov 21, 2024
gpanders
force-pushed
the
ganders/CC-4280
branch
3 times, most recently
from
1915bdc
to
60bdd91
Compare
gpanders
commented
Nov 22, 2024
gpanders
force-pushed
the
ganders/CC-4280
branch
2 times, most recently
from
96392ca
to
b094c83
Compare
Add a default image when using "wrangler cloudchamber create". This image is docker.io/cloudflare/hello-world which is a simple HTTP server that runs on Cloudflare's container platform. This commit also augments validation to both the `cloudchamber create` and `cloudchamber modify` commands to ensure the provided image contains a tag and adheres to the format in the OCI specification.
gpanders
force-pushed
the
ganders/CC-4280
branch
from
b094c83
to
c8e9562
Compare
edmundhung
approved these changes
Nov 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a default image when using "wrangler cloudchamber create". This image is docker.io/cloudflare/hello-world which is a simple HTTP server that runs on Cloudflare's container platform.
This commit also augments validation to both the
cloudchamber createandcloudchamber modifycommands to ensure the provided image contains a tag and adheres to the format in the OCI specification.Fixes CC-4280.