Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrangler pages deployment (list|tail) env filtering #7263

Conversation

danielrs
Copy link
Contributor

@danielrs danielrs commented Nov 14, 2024

Adds the --environment flag to wrangler pages deployment list, which should allow users to list deployments of a specific type. When the flag it's not provided it will list the latest 25 deployments regardless of type.

Additionally, makes sure we're listing the correct type of deployments when attempting to tail.

Fixes #6234.

Docs PR:
cloudflare/cloudflare-docs#18278


@danielrs danielrs requested review from a team as code owners November 14, 2024 19:56
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: c2e0a5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-wrangler-7263

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7263/npm-package-wrangler-7263

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-wrangler-7263 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-create-cloudflare-7263 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-kv-asset-handler-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-miniflare-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-pages-shared-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-vitest-pool-workers-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-workers-editor-shared-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-workers-shared-7263
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918687002/npm-package-cloudflare-workflows-shared-7263

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@danielrs danielrs force-pushed the drivas/issue-6234-wrangler-pages-deployments-list-environment-fixes branch 3 times, most recently from 54aa22b to 4dfa0d6 Compare November 19, 2024 16:15
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending one comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a minor, since it's adding a feature (env filtering)

Adds the --environment flag to `wrangler pages deployment list`, which
should allow users to list deployments of a specific type. When the flag
it's not provided it will list the latest 25 deployments regardless of
type.

Additionally, makes sure we're listing the correct type of deployments
when attempting to tail.
@danielrs danielrs force-pushed the drivas/issue-6234-wrangler-pages-deployments-list-environment-fixes branch from 4dfa0d6 to c2e0a5c Compare November 19, 2024 17:42
@penalosa
Copy link
Contributor

@danielrs could you make a docs ticket and link it to the PR description? I'll make sure this gets merged after CI passes

@danielrs
Copy link
Contributor Author

Created Docs PR:
cloudflare/cloudflare-docs#18278

@penalosa penalosa merged commit 1b80dec into main Nov 20, 2024
31 checks passed
@penalosa penalosa deleted the drivas/issue-6234-wrangler-pages-deployments-list-environment-fixes branch November 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: wrangler cannot find deployments past the first 25 records
3 participants