Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): fix failing R2 e2e test #7203

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Nov 8, 2024

Fixes n/a.

ad51d1d broke a related R2 e2e test, which we didn't see due to the fact that e2es were not run on that PR. This PR fixes the breakage.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: e2e test fix
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: e2e test fix

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner November 8, 2024 10:31
Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: 6cb409f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-wrangler-7203

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7203/npm-package-wrangler-7203

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-wrangler-7203 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-create-cloudflare-7203 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-kv-asset-handler-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-miniflare-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-pages-shared-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-vitest-pool-workers-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-workers-editor-shared-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-workers-shared-7203
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11741777086/npm-package-cloudflare-workflows-shared-7203

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 09bf6b8 into main Nov 8, 2024
22 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/r2-e2e branch November 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants