Implement --polyfill-node/ config.polyfill_node
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `--polyfill-node` as a cli argument and `polyfill_node` as a config field. It uses https://github.com/remorses/esbuild-plugins / https://github.com/ionic-team/rollup-plugin-node-polyfills/ for the polyfills. I also added a warning for the tradeoffs whenever this config is used. We may want better polyfills in the future, and maybe even better messaging if we can recognise popular libraries and suggest replacements.
|
|
|
threepointone
added a commit
that referenced
this pull request
Dec 13, 2021
The quality of the polyfills is quite bad, so I'm removing this implementation (introduced in #72)
This was referenced Dec 13, 2021
threepointone
added a commit
that referenced
this pull request
Dec 13, 2021
* remove `polyfill-node` / `polyfill_node` The quality of the polyfills is quite bad, so I'm removing this implementation (introduced in #72) * add a changeset * Update package-lock.json
GregBrimble
pushed a commit
that referenced
this pull request
Feb 8, 2024
this fixes an issue in serveSinglePageApp where the raw `request.url` string is being used as part of a conditional to retrieve static content - if a query parameter is set, it breaks the URL lookup. credit to @sgiacosa who wrote this code in #72 - this PR is a _very slight_ adaptation of his code sample! closes #72
GregBrimble
pushed a commit
that referenced
this pull request
Feb 9, 2024
this fixes an issue in serveSinglePageApp where the raw `request.url` string is being used as part of a conditional to retrieve static content - if a query parameter is set, it breaks the URL lookup. credit to @sgiacosa who wrote this code in #72 - this PR is a _very slight_ adaptation of his code sample! closes #72
GregBrimble
pushed a commit
that referenced
this pull request
Feb 9, 2024
this fixes an issue in serveSinglePageApp where the raw `request.url` string is being used as part of a conditional to retrieve static content - if a query parameter is set, it breaks the URL lookup. credit to @sgiacosa who wrote this code in #72 - this PR is a _very slight_ adaptation of his code sample! closes #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
--polyfill-nodeas a cli argument andpolyfill_nodeas a config field. It uses https://github.com/remorses/esbuild-plugins / https://github.com/ionic-team/rollup-plugin-node-polyfills/ for the polyfills. I also added a warning for the tradeoffs whenever this config is used. We may want better polyfills in the future, and maybe even better messaging if we can recognise popular libraries and suggest replacements.