Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WO-250 add workers-observability logs configuration #7173

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

Ankcorn
Copy link
Contributor

@Ankcorn Ankcorn commented Nov 5, 2024

Fixes #[WO-250].

Adds a nested logs configuration

Adds nested logs configuration to workers observability, this lets us add extra settings just for logs like toggling invocation logs.

[observability.logs]
enabled = true
invocation_logs = false
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation

@Ankcorn Ankcorn requested a review from a team as a code owner November 5, 2024 14:02
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: cc6d39b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ankcorn Ankcorn force-pushed the thomas/workers-observability branch from 78af501 to e6149e8 Compare November 5, 2024 14:06
Copy link
Contributor

github-actions bot commented Nov 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-wrangler-7173

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7173/npm-package-wrangler-7173

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-wrangler-7173 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-create-cloudflare-7173 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-kv-asset-handler-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-miniflare-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-pages-shared-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-vitest-pool-workers-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-workers-editor-shared-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-workers-shared-7173
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11841128369/npm-package-cloudflare-workflows-shared-7173

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@Ankcorn Ankcorn force-pushed the thomas/workers-observability branch from e6149e8 to dd99c24 Compare November 5, 2024 14:07
@Ankcorn Ankcorn force-pushed the thomas/workers-observability branch from dd99c24 to ffd6c74 Compare November 5, 2024 16:58
@zebp zebp added the e2e Run wrangler e2e tests on a PR label Nov 13, 2024
Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one minor comment, but I won't block merging.

@WalshyDev WalshyDev merged commit b6cbfbd into cloudflare:main Nov 14, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants