Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloudflare Pages command for Solid #7155

Merged

Conversation

flashblaze
Copy link
Contributor

Fix Cloudflare Pages command for Solid. Replaced ./cloudflare-pages by cloudflare-pages


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: It is a config string change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: It is a config string change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: It is a config string change

@flashblaze flashblaze requested review from a team as code owners November 2, 2024 16:03
Copy link

changeset-bot bot commented Nov 2, 2024

🦋 Changeset detected

Latest commit: 544f32b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.changeset/little-lamps-provide.md Outdated Show resolved Hide resolved
packages/create-cloudflare/package.json Outdated Show resolved Hide resolved
@flashblaze
Copy link
Contributor Author

Thanks @edmundhung. Do let me know if I missed anything or if I need to update anything else.

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will get this merged once all the CI is green 👍🏼

Copy link
Contributor

github-actions bot commented Nov 5, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-wrangler-7155

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7155/npm-package-wrangler-7155

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-wrangler-7155 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-create-cloudflare-7155 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-kv-asset-handler-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-miniflare-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-pages-shared-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-vitest-pool-workers-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-workers-editor-shared-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-workers-shared-7155
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11677300446/npm-package-cloudflare-workflows-shared-7155

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung merged commit edef523 into cloudflare:main Nov 5, 2024
19 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 5, 2024
Copy link

holopin-bot bot commented Nov 5, 2024

Congratulations @flashblaze, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm34d21u322460cl76uwbzohe

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants