Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudchamber: Render list of events with capitalised event messages, and render updated health enums. #7132

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Oct 30, 2024

With the introduction of health checks, we "health" status in placements have a new enum, update that and make the function to color the status more defensive. We are also capitalising the event messages on the placement list view.

If a user now creates a deployment with the wrong image architecture, they will see an error message that is not 404.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: uses interactivity (we still need to have a interactive test suite)
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: we don't have e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no documentation related.

@gabivlj gabivlj requested review from a team as code owners October 30, 2024 15:29
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 320e418

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 30, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-wrangler-7132

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7132/npm-package-wrangler-7132

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-wrangler-7132 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-create-cloudflare-7132 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-kv-asset-handler-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-miniflare-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-pages-shared-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-vitest-pool-workers-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-workers-editor-shared-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-workers-shared-7132
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11600096284/npm-package-cloudflare-workflows-shared-7132

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@gabivlj gabivlj force-pushed the gv/checks branch 3 times, most recently from 2f1805d to 320e418 Compare October 30, 2024 18:06
@gabivlj gabivlj merged commit 89f6274 into main Nov 4, 2024
20 checks passed
@gabivlj gabivlj deleted the gv/checks branch November 4, 2024 15:17
@workers-devprod workers-devprod mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants