fix: Modify Cloudchamber deployment labels in interactive mode #7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e3d48f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7124/npm-package-wrangler-7124Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-create-cloudflare-7124 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-kv-asset-handler-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-miniflare-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-pages-shared-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-vitest-pool-workers-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-editor-shared-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-shared-7124npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workflows-shared-7124Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
ichernetsky-cf
approved these changes
Oct 30, 2024
gpanders
approved these changes
Oct 30, 2024
gabivlj
approved these changes
Oct 30, 2024
edmundhung
requested changes
Oct 30, 2024
Depolyment label modification works as expected in non-interactive mode. However, during interactive mode, we do not add the required labels to the final API Request. Added labels fixture to modification tests as well.
skepticfx
force-pushed
the
nafeez/deployment-labels-interactive
branch
from
c6d5dad
to
e3d48f2
Compare
edmundhung
approved these changes
Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depolyment label modification works as expected in non-interactive mode. However, during interactive mode, we do not add the required labels to the final API Request.
Added labels fixture to modification tests as well.
Fixes CC-4451