Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out react from all non-dev flows #7065

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Rip out react from all non-dev flows #7065

merged 3 commits into from
Oct 23, 2024

Conversation

penalosa
Copy link
Contributor

Removes react from all non-dev flows, and replaces it with (depending on context):

  • logger.log()
  • logger.table()
  • spinner() from @cloudflare/cli/interactive
  • select()

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: internal refactor—the existing tests passing should give confidence that nothing has broken
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor

@penalosa penalosa requested review from a team as code owners October 23, 2024 10:14
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 9b4659b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-wrangler-7065

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7065/npm-package-wrangler-7065

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-wrangler-7065 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-create-cloudflare-7065 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-kv-asset-handler-7065
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-miniflare-7065
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-pages-shared-7065
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-vitest-pool-workers-7065
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-workers-editor-shared-7065
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-workers-shared-7065

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@RamIdeas RamIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Very close to removing react from all flows 🚀

@penalosa
Copy link
Contributor Author

penalosa commented Oct 23, 2024

Great stuff! Very close to removing react from all flows 🚀

PR on the way for the rest!

@penalosa penalosa added the e2e Run e2e tests on a PR label Oct 23, 2024
@penalosa penalosa merged commit b219296 into main Oct 23, 2024
27 of 28 checks passed
@penalosa penalosa deleted the penalosa/no-more-react branch October 23, 2024 11:58
@petebacondarwin
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants