-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rip out react from all non-dev flows #7065
Conversation
🦋 Changeset detectedLatest commit: 9b4659b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-wrangler-7065 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7065/npm-package-wrangler-7065 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-wrangler-7065 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-create-cloudflare-7065 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-kv-asset-handler-7065 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-miniflare-7065 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-pages-shared-7065 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-vitest-pool-workers-7065 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-workers-editor-shared-7065 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478137043/npm-package-cloudflare-workers-shared-7065 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Very close to removing react from all flows 🚀
PR on the way for the rest! |
🎉 |
Removes react from all non-dev flows, and replaces it with (depending on context):
logger.log()
logger.table()
spinner()
from@cloudflare/cli/interactive
select()