Skip to content

Only enable hotkeys after authenticating if hotkeys were previously enabled #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

penalosa
Copy link
Contributor

Fixes #7025

In --x-dev-env we temporarily disable hotkeys while doing account selection. Previously we'd been unconditionally re-enabling them, but this meant that --remote --show-interactive-dev-session would eventually show the hotkeys. This PR changes things to only re-enable hotkeys if they'd previously been enabled.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

@penalosa penalosa added the e2e Run wrangler + vite-plugin e2e tests on a PR label Oct 23, 2024
@penalosa penalosa requested a review from a team as a code owner October 23, 2024 08:38
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: ae28ccf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-wrangler-7064

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7064/npm-package-wrangler-7064

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-wrangler-7064 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-create-cloudflare-7064 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-cloudflare-kv-asset-handler-7064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-miniflare-7064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-cloudflare-pages-shared-7064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-cloudflare-vitest-pool-workers-7064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-cloudflare-workers-editor-shared-7064
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11476237487/npm-package-cloudflare-workers-shared-7064

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa merged commit a90980c into main Oct 23, 2024
22 checks passed
@penalosa penalosa deleted the 7025-bug-wrangler-dev-remote-using-interactive-dev-session-in-non-interactive-terminal-and-ignores-show-interactive-dev-session=false branch October 23, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR
Projects
None yet
2 participants