Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics to asset-worker #7053

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Oct 22, 2024

What this PR solves / how to test

Fixes #WC-2694

Adds analytics to the internal asset worker.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: internal change to instrument analytics
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner October 22, 2024 13:54
Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 2e91066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev added the skip-pr-description-validation Skip validation of the required PR description format label Oct 22, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-wrangler-7053

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7053/npm-package-wrangler-7053

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-wrangler-7053 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-create-cloudflare-7053 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-cloudflare-kv-asset-handler-7053
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-miniflare-7053
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-cloudflare-pages-shared-7053
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-cloudflare-vitest-pool-workers-7053
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-cloudflare-workers-editor-shared-7053
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11461725589/npm-package-cloudflare-workers-shared-7053

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa removed the skip-pr-description-validation Skip validation of the required PR description format label Oct 23, 2024
@WillTaylorDev WillTaylorDev merged commit 8dc2b7d into main Oct 23, 2024
30 of 32 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/add-analytics-asset-worker branch October 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants