Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce KV bulk upload size #7036

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Reduce KV bulk upload size #7036

merged 3 commits into from
Oct 23, 2024

Conversation

penalosa
Copy link
Contributor

Fixes #7021

Reduce the KV bulk upload size from 5_000 to 1_000 to try and help reduce API timeout issues


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: behaviour covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e coverage of KV
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal bugfix

@penalosa penalosa requested review from a team as code owners October 21, 2024 12:22
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 9b6213c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-wrangler-7036

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7036/npm-package-wrangler-7036

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-wrangler-7036 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-create-cloudflare-7036 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-kv-asset-handler-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-miniflare-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-pages-shared-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-vitest-pool-workers-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-workers-editor-shared-7036
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11475872222/npm-package-cloudflare-workers-shared-7036

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa marked this pull request as draft October 22, 2024 12:47
@penalosa
Copy link
Contributor Author

Moving this to draft pending internal discussion about whether or not this change will help things

Copy link
Contributor

@rts-rob rts-rob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per internal discussion, let's go ahead and make this change.

@penalosa penalosa marked this pull request as ready for review October 23, 2024 08:05
@penalosa penalosa merged commit e7ea600 into main Oct 23, 2024
20 checks passed
@penalosa penalosa deleted the penalosa-patch-10 branch October 23, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG:
4 participants