Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better errors for workers commands in pages projects #6996

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Oct 16, 2024

What this PR solves / how to test

Fixes #6793

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered adequately by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just some better errors

@emily-shen emily-shen requested a review from a team as a code owner October 16, 2024 12:40
Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 8b7ee50

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-wrangler-6996

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6996/npm-package-wrangler-6996

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-wrangler-6996 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-create-cloudflare-6996 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-cloudflare-kv-asset-handler-6996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-miniflare-6996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-cloudflare-pages-shared-6996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-cloudflare-vitest-pool-workers-6996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-cloudflare-workers-editor-shared-6996
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11384003830/npm-package-cloudflare-workers-shared-6996

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen marked this pull request as draft October 16, 2024 17:59
@emily-shen emily-shen marked this pull request as ready for review October 16, 2024 18:30
@emily-shen emily-shen marked this pull request as draft October 16, 2024 19:41
@emily-shen emily-shen marked this pull request as ready for review October 17, 2024 09:46
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall...just a copy nit to make the error more user friendly, and more comprehensive <3

@emily-shen emily-shen merged commit b8ab809 into main Oct 17, 2024
20 checks passed
@emily-shen emily-shen deleted the emily/better-pages-errors branch October 17, 2024 12:26
@irvinebroque
Copy link
Contributor

Love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Throw an actionable error if we detect a Pages project using Workers commands
3 participants