Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update Angular template to version 19 #6960

Merged
merged 2 commits into from
Nov 21, 2024
Merged

feat: Update Angular template to version 19 #6960

merged 2 commits into from
Nov 21, 2024

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Oct 14, 2024 •
edited by petebacondarwin
Loading

This prerelease version 19 includes several developer experience (DX) improvements:

  • Introduces a new server routing API
  • Portable with no Node.js dependencies
  • Supports a "neutral" output format

Fixes #0000

Author has addressed the following

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4f20c66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alan-agius4 alan-agius4 force-pushed the update-ng-19 branch 2 times, most recently from ef32edb to 9cbb7fd Compare October 17, 2024 07:12
@alan-agius4 alan-agius4 marked this pull request as ready for review October 17, 2024 07:13
@alan-agius4 alan-agius4 requested review from a team as code owners October 17, 2024 07:13
@petebacondarwin
Copy link
Contributor

Cool! Thanks for putting this together @alan-agius4 - I'll try running the e2e tests on our fork to check it is all good.

petebacondarwin
petebacondarwin reviewed Oct 17, 2024
View reviewed changes
packages/create-cloudflare/templates/angular/c3.ts
@@ -93,8 +104,7 @@ const config: TemplateConfig = {
scripts: {
start: `${npm} run build && wrangler pages dev dist/cloudflare ${await compatDateFlag()} --experimental-local`,
build: `ng build && ${npm} run process`,
process:
"node ./tools/copy-files.mjs && node ./tools/alter-polyfills.mjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

petebacondarwin
petebacondarwin reviewed Oct 17, 2024
View reviewed changes
packages/create-cloudflare/templates/angular/c3.ts
// Remove unwanted dependencies
s.start(`Updating package.json`);
const packageJsonPath = resolve("package.json");
const packageManifest = readJSON(packageJsonPath);

delete packageManifest["dependencies"]["@angular/ssr"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@petebacondarwin petebacondarwin self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-wrangler-6960

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6960/npm-package-wrangler-6960

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-wrangler-6960 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-create-cloudflare-6960 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-kv-asset-handler-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-miniflare-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-pages-shared-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-vitest-pool-workers-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-workers-editor-shared-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-workers-shared-6960
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11960808853/npm-package-cloudflare-workflows-shared-6960

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

petebacondarwin
petebacondarwin approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests pass on pnpm and Mac for me locally!

Do we want to wait for Angular 19 to come out of pre-release @alan-agius4 ?

@petebacondarwin petebacondarwin added the skip-pr-description-validation Skip validation of the required PR description format label Oct 17, 2024
@alan-agius4
Copy link
Contributor Author

Do we want to wait for Angular 19 to come out of pre-release @alan-agius4 ?

SGTM, the final is schedule in mid November, and RC later this month.

@petebacondarwin
Copy link
Contributor

Do we want to wait for Angular 19 to come out of pre-release @alan-agius4 ?

SGTM, the final is schedule in mid November, and RC later this month.

How about we bump this when the RC is out to encourage testing of the new version?

@petebacondarwin petebacondarwin added the blocked Blocked on other work label Oct 17, 2024
@alan-agius4
Copy link
Contributor Author

Sure, thanks

@alan-agius4 alan-agius4 force-pushed the update-ng-19 branch 2 times, most recently from 894e704 to 4c33e9a Compare November 20, 2024 14:11
@alan-agius4
Copy link
Contributor Author

@petebacondarwin, version 19 has been released as stable.

@petebacondarwin petebacondarwin removed the blocked Blocked on other work label Nov 21, 2024
alan-agius4 and others added 2 commits November 21, 2024 20:03
@alan-agius4 @petebacondarwin
feat: Update Angular template to version 19
8c45043 
This prerelease version 19 includes several developer experience (DX) improvements:
- Introduces a new server routing API
- Portable with no Node.js dependencies
- Supports a "neutral" output format
@petebacondarwin
fix formatting
4f20c66
@petebacondarwin petebacondarwin merged commit 3e52c7c into cloudflare:main Nov 21, 2024
28 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 21, 2024
@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Nov 21, 2024

Congratulations @alan-agius4, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3rt86kt59690cmqckvpy5md

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Nov 21, 2024
Merged
jakkal6

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakkal6 jakkal6 jakkal6 left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees

@petebacondarwin petebacondarwin

Labels
contribution [Holopin] Recognizes an open-source contribution, big or small skip-pr-description-validation Skip validation of the required PR description format
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alan-agius4 @petebacondarwin @jakkal6 @workers-devprod