Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade chokidar to v4 #6795

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Sep 22, 2024

What this PR solves / how to test

Upgrades to the latest version of chokidar

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: functionality should already be covered by tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by non-e2e
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: docs are all still accurate

@benmccann benmccann requested a review from a team as a code owner September 22, 2024 15:26
Copy link

changeset-bot bot commented Sep 22, 2024

🦋 Changeset detected

Latest commit: c9b60f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-wrangler-6795

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6795/npm-package-wrangler-6795

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-wrangler-6795 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-create-cloudflare-6795 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-kv-asset-handler-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-miniflare-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-pages-shared-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-vitest-pool-workers-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-workers-editor-shared-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-workers-shared-6795
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11806228903/npm-package-cloudflare-workflows-shared-6795

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@talentlessguy
Copy link

Any chance for this to be merged?

@benmccann benmccann closed this Nov 11, 2024
@benmccann benmccann deleted the chokidar-4 branch November 11, 2024 15:52
@benmccann
Copy link
Contributor Author

benmccann commented Nov 11, 2024

Happy to update this if we can get confirmation it's going to be merged, but I'm not going to do the work of keeping it up-to-date otherwise

@penalosa
Copy link
Contributor

@benmccann apologies, this completely slipped off our radar. Could you re-open? I'll make sure this gets merged & released—thanks for the PR!

@benmccann benmccann restored the chokidar-4 branch November 12, 2024 21:36
@benmccann benmccann reopened this Nov 12, 2024
@benmccann
Copy link
Contributor Author

thanks @penalosa! I've reopened and rebased this PR

@penalosa penalosa merged commit 94f07ee into cloudflare:main Nov 12, 2024
27 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Nov 12, 2024
Copy link

holopin-bot bot commented Nov 12, 2024

Congratulations @benmccann, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm3f2dcjl17710cme59lk4opl

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants